Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeemers serialization fixes #4040

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Feb 2, 2024

Description

This PR addresses part of the #3922 ticket, namely switched redeemers to use Map encoding by default

It also fixes CDDL for Conway PParams

Extra nice cleanup is addition of Map conversion functions and deprecation of keyBy

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/redeemers-serialization-fixes branch 2 times, most recently from b33ea61 to 8c7edc4 Compare February 2, 2024 15:59
@lehins lehins requested a review from teodanciu February 2, 2024 15:59
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins mentioned this pull request Feb 2, 2024
4 tasks
@lehins lehins force-pushed the lehins/redeemers-serialization-fixes branch from 8c7edc4 to b57d92c Compare February 2, 2024 21:35
@lehins lehins enabled auto-merge February 2, 2024 21:35
@lehins lehins merged commit e8f225c into master Feb 2, 2024
11 of 20 checks passed
@neilmayhew neilmayhew deleted the lehins/redeemers-serialization-fixes branch March 8, 2024 21:07
rooooooooob added a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request Mar 28, 2024
SebastienGllmt pushed a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request May 1, 2024
* New Conway.cddl updates (cml-chain/cml-chain-wasm)

Includes:
* IntersectMBO/cardano-ledger#4003
* IntersectMBO/cardano-ledger#4178
* IntersectMBO/cardano-ledger#4055
* IntersectMBO/cardano-ledger#4117
* IntersectMBO/cardano-ledger#4040

TODO:

[ ] need to check how this affects the script data hash and test that
[ ] multi-era

* conway multi-era update + various fixes

* resolve merge conflict

* use conway costmodels for all eras (babbage costmdls found in alonzo on sancho testnet)

* IntoIter for NonemptySet<T>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants