New Conway.cddl updates #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era
ecioppettini
reviewed
Apr 4, 2024
| } | ||
| } | ||
|
|
||
| impl<T> AsRef<[T]> for NonemptySet<T> { |
There was a problem hiding this comment.
would be nice to also have IntoIterator for &'a NonemptySet<T> and I guess NonemptySet<T> I think. For loop syntax is quite convenient.
There was a problem hiding this comment.
Just pushed this. Added:
impl<T> IntoIterator for NonemptySet<T>
impl<'a, T> IntoIterator for &'a NonemptySet<T>
impl<'a, T> IntoIterator for &'a mut NonemptySet<T>
- same for
NonemptySetRawBytes.
There was a problem hiding this comment.
Is there anything else we need or should Deref and DerefMut take care of that?
ecioppettini
reviewed
Apr 4, 2024
rooooooooob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Also includes a fix for Nonce::Identity parsing introduced in #312