-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Conway.cddl updates #324
Conversation
Includes: * IntersectMBO/cardano-ledger#4003 * IntersectMBO/cardano-ledger#4178 * IntersectMBO/cardano-ledger#4055 * IntersectMBO/cardano-ledger#4117 * IntersectMBO/cardano-ledger#4040 TODO: [ ] need to check how this affects the script data hash and test that [ ] multi-era
} | ||
} | ||
|
||
impl<T> AsRef<[T]> for NonemptySet<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to also have IntoIterator for &'a NonemptySet<T>
and I guess NonemptySet<T>
I think. For loop syntax is quite convenient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed this. Added:
impl<T> IntoIterator for NonemptySet<T>
impl<'a, T> IntoIterator for &'a NonemptySet<T>
impl<'a, T> IntoIterator for &'a mut NonemptySet<T>
- same for
NonemptySetRawBytes
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything else we need or should Deref
and DerefMut
take care of that?
Includes:
Also includes a fix for Nonce::Identity parsing introduced in #312