-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible costmodel params #4284
Conversation
9c0353f
to
bd0c660
Compare
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Instances.hs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far all I've seen is this typo
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/CostModels.hs
Outdated
Show resolved
Hide resolved
eras/alonzo/impl/testlib/Test/Cardano/Ledger/Alonzo/Binary/CostModelsSpec.hs
Outdated
Show resolved
Hide resolved
25904f5
to
3e472d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and I think I understand the changes well enough.
I've made a minor suggestion for improving the wording of a comment, but feel free to ignore this if you don't want to delay merging.
libs/cardano-ledger-core/src/Cardano/Ledger/Plutus/CostModels.hs
Outdated
Show resolved
Hide resolved
7b6721c
to
f9324de
Compare
Due to changes here: IntersectMBO/cardano-ledger#4284 Clarification here: IntersectMBO/cardano-ledger#4383 Allows non-Plutus languages according to the spec and changes to an indexable map type.
Due to changes here: IntersectMBO/cardano-ledger#4284 Clarification here: IntersectMBO/cardano-ledger#4383 Allows non-Plutus languages according to the spec and changes to an indexable map type.
Due to changes here: IntersectMBO/cardano-ledger#4284 Clarification here: IntersectMBO/cardano-ledger#4383 Allows non-Plutus languages according to the spec and changes to an indexable map type.
Description
Fixes in this PR:
Int64
instead ofInteger
. See an accompanied change in plutus: Use Int64 in CostModelParams plutus#5920Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)