Cost models update conway #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to changes here: IntersectMBO/cardano-ledger#4284 Clarification here: IntersectMBO/cardano-ledger#4383 Allows non-Plutus languages according to the spec and changes to an indexable map type.
rooooooooob
commented
Jun 18, 2024
| impl TryFrom<u64> for Language { | ||
| type Error = DeserializeError; | ||
|
|
||
| fn try_from(language: u64) -> Result<Self, Self::Error> { |
There was a problem hiding this comment.
I am also thinking of just getting rid of the Language enum entirely and swapping it with just pub type Language = u64 then maybe a Languages module with V1/V2/V3 members to avoid having to convert to/from u64/Language via From/TryFrom
rooooooooob
commented
Jun 18, 2024
| @@ -354,52 +343,69 @@ impl CostModels { | |||
| let mut serializer = Serializer::new_vec(); | |||
| // as canonical encodings are used, we odn't need to check the keys' bytes encodings | |||
| // and can order this statically. | |||
| serializer.write_map(cbor_event::Len::Len( | |||
There was a problem hiding this comment.
This might be the reason why the plutus stuff wasn't being accepted in March, I need to look into it more. This should be fixed now. (the length calculation didn't take into account v3)
SebastienGllmt
approved these changes
Jun 18, 2024
| @@ -720,13 +720,12 @@ impl TransactionBuilder { | |||
|
|
|||
| match &script_witness.script { | |||
| PlutusScriptWitness::Ref(ref_script) => { | |||
| if self | |||
| if !self | |||
There was a problem hiding this comment.
These diffs should go away if you rebase
rooooooooob
added a commit
that referenced
this pull request
Jul 23, 2024
rooooooooob
added a commit
that referenced
this pull request
Jul 23, 2024
Due to changes here: IntersectMBO/cardano-ledger#4284 Clarification here: IntersectMBO/cardano-ledger#4383 Allows non-Plutus languages according to the spec and changes to an indexable map type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to changes here: IntersectMBO/cardano-ledger#4284
Clarification here: IntersectMBO/cardano-ledger#4383
Allows non-Plutus languages according to the spec and changes to an indexable map type.