Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search, filters etc to GA for Voted on view #1

Closed
l-br1 opened this issue Dec 13, 2023 · 4 comments
Closed

Add search, filters etc to GA for Voted on view #1

l-br1 opened this issue Dec 13, 2023 · 4 comments
Assignees
@m-i-k-e

Comments

@l-br1
Copy link

l-br1 commented Dec 13, 2023 •
edited
Loading

Currently search, filter and sort don't work across tabs.

At least for search we need to have that working across tabs and add filter and sort in the other tab
@l-br1 l-br1 self-assigned this Dec 13, 2023
@Thomas-Upfield
Copy link

@l-br1 search is broken as confirmed in another ticket, but the sort and filter seem to work ok. The real problem is that when you click on a governance action to view details then click back to the Governance Actions page the filters are not retained.

@Thomas-Upfield
Copy link

@m-i-k-e I'm of the mind that we should leave this until the new tabular design is implemented. What do you think? No use fixing something that we're going to change anyway.

@l-br1
Copy link
Author

l-br1 commented Feb 5, 2024

@Thomas-Upfield @m-i-k-e this ticket was related to having search and filtering also working when I am a DRep, so I can search and filter in both 'to vote' and 'voted' tab. Regardless of any different view we might apply in the future to GA list this is a 'Milestone 4' bug from previous SoW which we should try to work on after we started dev of the new features :)

@m-i-k-e m-i-k-e assigned m-i-k-e and unassigned l-br1 Feb 20, 2024
@m-i-k-e
Copy link

m-i-k-e commented Mar 21, 2024

Sorted for this phase

@m-i-k-e m-i-k-e closed this as completed Mar 21, 2024
@l-br1 l-br1 added this to Govtool all Apr 2, 2024
placek added a commit that referenced this issue May 17, 2024
@placek
Squashed 'govtool/analytics-dashboard/' changes from 9d116a9..a47b9c2
6bf322d 
a47b9c2 Merge pull request #2 from IntersectMBO/feat/icon-and-changes
8bb51a5 fix: favicon theme
56d39a9 Merge pull request #1 from IntersectMBO/feat/icon-and-changes
af210c9 fix favicon and text

git-subtree-dir: govtool/analytics-dashboard
git-subtree-split: a47b9c276dc0d196cf2d497981925a417113d1e2
@placek placek mentioned this issue May 17, 2024
Merged
@pmbinapps pmbinapps mentioned this issue Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-i-k-e m-i-k-e

Labels
None yet
Projects
Govtool all
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-i-k-e @Thomas-Upfield @l-br1