Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As dRep - on proposal after Voted - Back and Reload the vote decision button is not updated [BT-ensure prio low] #2

Closed
l-br1 opened this issue Dec 13, 2023 · 4 comments
Labels
🐛 Bug Something isn't working

Comments

@l-br1
Copy link

l-br1 commented Dec 13, 2023

To reproduce:

As dRep on a proposal, choose decision and Vote

Click back on browser

Reload - the decision buttons YES, NO, ABSTAIN are not updated as the would after entering from Voted on section

Screen.Recording.2023-09-29.at.09.56.46.mp4
@l-br1 l-br1 self-assigned this Dec 13, 2023
@l-br1
Copy link
Author

l-br1 commented Dec 13, 2023

from Pawel 22nd November

'BT: Lowered prio, to confirm, occurs but transaction is blocked now.'

Screen.Recording.2023-11-22.at.15.15.45.mov-shrunk.mp4

@l-br1
Copy link
Author

l-br1 commented Dec 13, 2023

from Michal S. 23rd Nov 2023
'BT

Was this connected to the missing in-progress state?

The in-progress state exists and is active when working on one tab. On multiple tabs the state is not shared.

Affected: Frontend

Reason: There is no update of the state of governance actions when the page is reloaded. However, bug occurs on two tabs and/or while routing back (which is more likely to happen). Workaround exists and the generic solution for this kind of bugs might require more time to implement to be worthy of this level of priority.

Proposed solution: Implement mechanism that blocks the user inputs (disable buttons) when the action is performing.
Alternative:
Implement mechanism to disable interactions when user is active on different tab (common scenario for the banking apps).

Additional
As I can see this is another situation where we expect the asynchronous change synchronously. In my opinion, we should implement some listeners to those actions to avoid repeating types of bugs.

@l-br1 l-br1 added this to Govtool all Apr 2, 2024
@l-br1 l-br1 added the 🐛 Bug Something isn't working label Apr 2, 2024
@l-br1 l-br1 moved this to Backlog in Govtool all Apr 2, 2024
@pmbinapps
Copy link

@MSzalowski MSzalowski moved this from Backlog to In QA in Govtool all May 13, 2024
@pmbinapps pmbinapps moved this from In QA to In staging in Govtool all May 16, 2024
placek added a commit that referenced this issue May 17, 2024
a47b9c2 Merge pull request #2 from IntersectMBO/feat/icon-and-changes
8bb51a5 fix: favicon theme
56d39a9 Merge pull request #1 from IntersectMBO/feat/icon-and-changes
af210c9 fix favicon and text

git-subtree-dir: govtool/analytics-dashboard
git-subtree-split: a47b9c276dc0d196cf2d497981925a417113d1e2
@MSzalowski MSzalowski moved this from In staging to Done in Govtool all Jun 13, 2024
@Ryun1
Copy link
Member

Ryun1 commented Aug 7, 2024

very old, lets close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants