Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 ADA quantities format should avoid thousands when the total is 0 #2372

Closed
bosko-m opened this issue Nov 14, 2024 · 0 comments · Fixed by #2396
Closed

🐛 ADA quantities format should avoid thousands when the total is 0 #2372

bosko-m opened this issue Nov 14, 2024 · 0 comments · Fixed by #2396
Assignees
@MSzalowski
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Milestone
🏛 Needed for Full...

Comments

@bosko-m
Copy link
Contributor

bosko-m commented Nov 14, 2024

Area

Voting Pillar

Domain

gov.tools

Which wallet were you using?

No response

Context

I was testing #2305 and notices it adds thousands even if the total iz 0.

Steps to reproduce

  1. Go to any GA
  2. Click to show Votes

Actual behavior

It is displaying thousands when the total is 0 (0,000)

Expected behavior

It shouldnt display thousands when the total is 0 (should just be 0)
@bosko-m bosko-m added the 🐛 Bug Something isn't working label Nov 14, 2024
@bosko-m bosko-m moved this to To do in Govtool all Nov 14, 2024
@bosko-m bosko-m mentioned this issue Nov 14, 2024
Closed
@MSzalowski MSzalowski moved this from To do to In review in Govtool all Nov 20, 2024
@MSzalowski MSzalowski moved this from In review to In progress in Govtool all Nov 20, 2024
MSzalowski added a commit that referenced this issue Nov 20, 2024
@MSzalowski
fix(#2372): fix ada quantities format
72644e2
@MSzalowski MSzalowski mentioned this issue Nov 20, 2024
Merged
5 tasks
@MSzalowski MSzalowski linked a pull request Nov 20, 2024 that will close this issue
fix(#2372): fix ada quantities format #2396
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Nov 20, 2024
MSzalowski added a commit that referenced this issue Nov 20, 2024
@MSzalowski
fix(#2372): fix ada quantities format
e27ab29
MSzalowski added a commit that referenced this issue Nov 20, 2024
@MSzalowski
Merge pull request #2396 from IntersectMBO/fix/2372--ada-quantities-f…
1663f56 
…ormat-should-avoid-thousands-when-the-total-is-0

fix(#2372): fix ada quantities format
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#2372): fix ada quantities format IntersectMBO/govtool
2 participants
@MSzalowski @bosko-m