Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no 404 page in drep directory #928

Closed
m-i-k-e opened this issue May 1, 2024 · 4 comments · Fixed by #1018
Closed

no 404 page in drep directory #928

m-i-k-e opened this issue May 1, 2024 · 4 comments · Fixed by #1018
Assignees
Labels
🐛 Bug Something isn't working

Comments

@m-i-k-e
Copy link

m-i-k-e commented May 1, 2024

Context & versions

staging.sanchonet

Steps to reproduce

  1. Go to a Drep detail page
  2. Add any character to the end of the url
  3. hit return

Loom video

https://www.loom.com/share/709bf5a3f1ca44a997938f05ea93c90c?sid=8ae0da24-5e01-4048-87f0-18a5962a6cc4

Actual behavior

You go to a page with an endless spinner

Expected behavior

You should have a page not found or Drep not found error

@m-i-k-e m-i-k-e added the 🐛 Bug Something isn't working label May 1, 2024
@pmbinapps
Copy link

Valid bug - page not found is not shown, instead endless loader is shown.

@pmbinapps
Copy link

Now loader is shown:

Image

Request should return similary like GA not found.

@pmbinapps pmbinapps moved this to To do in Govtool all May 7, 2024
@m-i-k-e
Copy link
Author

m-i-k-e commented May 13, 2024

@MSzalowski MSzalowski removed their assignment May 13, 2024
@vercia vercia linked a pull request May 14, 2024 that will close this issue
5 tasks
@vercia vercia self-assigned this May 14, 2024
@Sworzen1 Sworzen1 moved this from To do to In review in Govtool all May 14, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 15, 2024
@MSzalowski MSzalowski moved this from Done to In QA in Govtool all May 15, 2024
@pmbinapps
Copy link

OK - Drep - not found shown instead:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants