Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong DRep type returned after change from DRep to Direct Voter #957

Closed
JanJaroszczak opened this issue May 8, 2024 · 1 comment · Fixed by #1001
Closed

Wrong DRep type returned after change from DRep to Direct Voter #957

JanJaroszczak opened this issue May 8, 2024 · 1 comment · Fixed by #1001
Assignees
@JanJaroszczak @jankun4
Labels
⚙ Backend 🐛 Bug Something isn't working

Comments

@JanJaroszczak
Copy link
Contributor

JanJaroszczak commented May 8, 2024 •
edited
Loading

When a user, so far registered as DRep, registers as Direct Voter:

  • ada-holder/get-current-delegation/{stakekey} returns:
    Image

  • drep/info/{drepId} returns (isRegisteredAsSoleVoter: true):
    Image

  • but drep/list?page=0&pageSize=10&search={dRepView of myself} still returns type: "DRep":
    Image
@JanJaroszczak JanJaroszczak converted this from a draft issue May 8, 2024
@JanJaroszczak JanJaroszczak added ⚙ Backend 🐛 Bug Something isn't working labels May 8, 2024
@JanJaroszczak JanJaroszczak mentioned this issue May 8, 2024
Closed
jankun4 added a commit that referenced this issue May 13, 2024
@jankun4
[#957] drep/list drep type fix
90f1e02
@jankun4 jankun4 mentioned this issue May 13, 2024
Merged
5 tasks
@jankun4 jankun4 linked a pull request May 13, 2024 that will close this issue
[#957] drep/list drep type fix #1001
Merged
5 tasks
@MSzalowski MSzalowski moved this from To do to In review in Govtool all May 13, 2024
MSzalowski added a commit that referenced this issue May 15, 2024
@MSzalowski
Merge pull request #1001 from IntersectMBO/957-wrong-drep-type-return…
d7545cb 
…ed-after-change-from-drep-to-direct-voter

[#957] drep/list drep type fix
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all May 15, 2024
@MSzalowski MSzalowski mentioned this issue May 15, 2024
Merged
@MSzalowski MSzalowski moved this from Done to In QA in Govtool all May 15, 2024
@MSzalowski MSzalowski mentioned this issue May 15, 2024
Closed
@pmbinapps
Copy link

pmbinapps commented May 15, 2024 •
edited
Loading

OK when user is Retired as Direct Voter and Registered as DRep:

Image

NOT OK when user Retired as DRep and Registred as Direct Voter - his DRep id is not retrived by /drep/list endpoing

Image

@JanJaroszczak @jankun4 please consult if regarding above

@pmbinapps pmbinapps moved this from In QA to To do in Govtool all May 15, 2024
MSzalowski added a commit that referenced this issue May 16, 2024
@MSzalowski
Merge pull request #1030 from IntersectMBO/develop
f307ebd 
Sync test with develop: #957, #1028, #928, #1019
@pmbinapps pmbinapps mentioned this issue May 16, 2024
Merged
@bosko-m bosko-m moved this from To do to In staging in Govtool all May 21, 2024
@bosko-m bosko-m moved this from In staging to Done in Govtool all Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanJaroszczak JanJaroszczak

@jankun4 jankun4

Labels
⚙ Backend 🐛 Bug Something isn't working
Projects
Govtool all
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#957] drep/list drep type fix IntersectMBO/govtool
3 participants
@JanJaroszczak @jankun4 @pmbinapps