Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide tags to sentry events #1399

Merged

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • provide tags to sentry events

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jun 21, 2024 that may be closed by this pull request
@MSzalowski MSzalowski force-pushed the chore/1326-group-the-same-sentry-issues-eg-wallet branch from b3fbc40 to cfac7ab Compare June 21, 2024 10:19
@MSzalowski MSzalowski requested review from placek and adgud as code owners June 21, 2024 10:19
@MSzalowski MSzalowski force-pushed the chore/1326-group-the-same-sentry-issues-eg-wallet branch from cfac7ab to cdffe5b Compare June 21, 2024 10:20
@MSzalowski MSzalowski force-pushed the chore/1326-group-the-same-sentry-issues-eg-wallet branch from cdffe5b to 4ab7602 Compare June 21, 2024 10:25
Copy link
Contributor

@spannercode spannercode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSzalowski Nice job adding tags 👍

As an idea, can we have tag (key part) as generic and searchable/rememberable?

For some of the tags, it might sense to make them as part of breadcrumb.
Reference: https://docs.sentry.io/platforms/javascript/enriching-events/breadcrumbs/

@MSzalowski MSzalowski force-pushed the chore/1326-group-the-same-sentry-issues-eg-wallet branch from 4ab7602 to 5927409 Compare June 21, 2024 12:38
@MSzalowski MSzalowski force-pushed the chore/1326-group-the-same-sentry-issues-eg-wallet branch from 5927409 to f5507e8 Compare June 21, 2024 14:00
@MSzalowski MSzalowski merged commit 17d782e into develop Jun 21, 2024
5 checks passed
@MSzalowski MSzalowski deleted the chore/1326-group-the-same-sentry-issues-eg-wallet branch June 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group the same sentry issues (eg.: wallet)
3 participants