-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DRep voting power handling, metadata validator, Sentry config; Fix CSP, navigation, modal, vote issues; Update proposal-id, DRep navigation, yarn; Improve tests. #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test-infra: Expose storybook deployment publicly
Add USERSNAP_SPACE_API_KEY configuration in test deployment
The Content Security Policy (CSP) was updated to resolve the issue that was blocking Sentry requests. Previously, the `connect-src` directive did not include wildcard entries for Sentry endpoints, causing POST requests to the Sentry API to fail. The configuration was adjusted to permit requests to any instance of Sentry under the `*.ingest.sentry.io` domain. This change ensures that error tracking and monitoring via Sentry can function correctly, as required by the user story. The updated CSP also maintains security best practices and has been tested to confirm successful transmission of error data to Sentry.
…-blocking-sentry-requests-in-traefik-configuration [#1218] Resolve CSP issue blocking Sentry requests in Traefik configuration
chore: Update proposal-id for frontend validation in sorting
Fix/metadata validation
Fix/drep ga missing test ids
Bugfix/test-2N-3M
fix/console-errors
Refactor/test docs url link
…nalysis chore: fix flaky tests
…-validator-to-pdf-pillar feat: pass govtool metadata validator to pdf pillar
…sentry-issues-eg-wallet chore: provide tags to sentry events
…-field-on-edit-drep-form-causes-it-to-reappear-and-adds-extra-link-input fix/1389-bug-clearing-name-field-on-edit-drep-form-causes-it-to-reappear-and-adds-extra-link-input
…iscussion fix(#1349): Change label of Proposal Discussion nav item
fix(#1355): fix the navigation to Home from Proposal pillar on disconnected wallet
pmbinapps
requested review from
placek,
adgud,
MSzalowski,
Sworzen1,
JanJaroszczak and
Ryun1
as code owners
June 24, 2024 12:38
MSzalowski
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add:
#1093 Return 0 DRep voting power instead of throwing 500
#1374 Pass govtool metadata validator to PDF pillar
Add Sentry Backend DSN in playbook
Expose storybook deployment publicly
Add USERSNAP_SPACE_API_KEY build-arg
Fix:
#1218 Fix CSP issue blocking Sentry requests in Traefik configuration
#1355 Fix navigation to Home from Proposal pillar on disconnect
#1349 Change label of Proposal Discussion nav item
Fix metadata error modal
Fix edit DRep form
Fix modal ref error
Fix tab index modal
Fix nested p error
Fix cannot get value from undefined and improve Sanchonet info modal
Fix navigation
Fix dashboard and homepage learn more navigation link
Fix abstain and signal-no-confidence info navigation URL
Fix vote
Fix flaky tests
Fix metadata-validation default URL
Fix console errors
Fix missing test IDs on DRepDirectory page
Fix missing test IDs on DRep Registration page
Fix missing test IDs on GA page
Change:
Update proposal-id for frontend validation in sorting
Change navigation of DRep details page
Replace hardcoded docs URL with constant
Provide tags to Sentry events
Update matadata-anchor incorrect test IDs
Add email and bio data on update DRep test
Add "add link" button click event on edit DRep
Update yarn
Upgrade cardano-db-sync to sancho-5-0-0
Merged PRs:
Merge pull request #1356 from IntersectMBO/fix/storybook-deployment
Merge pull request #1359 from IntersectMBO/infra/test-chores
Merge pull request #1362 from IntersectMBO/bug/1218-resolve-csp-issue
Merge pull request #1360 from IntersectMBO/bugfix/test-4C_2
Merge pull request #1395 from IntersectMBO/fix/metadata-validation
Merge pull request #1394 from IntersectMBO/fix/dRep-GA-missing-test-ids
Merge pull request #1396 from IntersectMBO/bugfix/test-2N-3M
Merge pull request #1337 from IntersectMBO/fix/console-errors
Merge pull request #1392 from IntersectMBO/refactor/test-docs-url-link
Merge pull request #1373 from IntersectMBO/chore/1334-fix-sonarqube
Merge pull request #1402 from IntersectMBO/fix/vote
Merge pull request #1399 from IntersectMBO/chore/1326-group-the-same
Merge pull request #1397 from IntersectMBO/fix/1389-bug-clearing-name
Merge pull request #1411 from IntersectMBO/fix/1349-change-proposal-discussion
Merge pull request #1412 from IntersectMBO/fix/1355-user-get-stack