Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

draft changes needed for sript dreps #1956

Closed
wants to merge 1 commit into from
Closed

draft changes needed for sript dreps #1956

wants to merge 1 commit into from

Conversation

Ryun1
Copy link
Member

@Ryun1 Ryun1 commented Sep 5, 2024

List of changes

  • Add / Fix / Change / Remove

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ryun1 Ryun1 mentioned this pull request Sep 5, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

❌ Docker Image Scan (Dockle) failed

No output

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

✅ All checks succeeded

@jdyczka
Copy link
Contributor

jdyczka commented Sep 27, 2024 •
edited
Loading

I would think that formHexToBech32 is only used in places where there is no view returned from the API available. Shouldn't we also make that change on BE?

@jdyczka
Copy link
Contributor

jdyczka commented Oct 22, 2024

solved in a new PR #2182

@Ryun1 Ryun1 closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski will be requested when the pull request is marked ready for review MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka will be requested when the pull request is marked ready for review jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryun1 @jdyczka