-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#81] configure unit tests with vitest #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide better PR description pls (remove default).
You could also update README informing about tests (technology used & how to run them)
In future can we please try and keep the pull requests smaller, as per the agreed Working Conventions, keeping PRs "Well-scoped - we prefer multiple PRs, rather than a big one" |
Good point. For example that pr could be split into:
I wonder if in such cases where multiple PRs are about the same functionality (based on the above - vitest config brings nothing without tests) - wouldn't it be better, to have one global branch that would have smaller PRs to that branch and when they all are merged that global branch would have pr (big one - but with all the already reviewed and checked changes from smaller PRs) to main - just a typical git flow - would it be acceptable @Ryun1? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@JanJaroszczak Can you rebase that branch to develop? |
ba16175
to
8c09303
Compare
I changed the base branch to develop on this PR and rebased (and squashed) commits delivered by @JanJaroszczak with 8c09303 Changes are assigned to me on git, but the author is @JanJaroszczak |
Implementation of unit tests made with Vitest.
Test were written for utils functions used in the project.