Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#897] Slow delegation issue // usePendingTransaction fixes #947

Merged
merged 1 commit into from
May 7, 2024
Merged

[#897] Slow delegation issue // usePendingTransaction fixes #947

merged 1 commit into from
May 7, 2024

Conversation

JanJaroszczak
Copy link
Contributor

@JanJaroszczak JanJaroszczak commented May 7, 2024 •
edited
Loading

`usePendingTransaction behavior for delegation and Direct Voter registration/retirement fixed.
Unnecessary delegation success snackbar removed.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@JanJaroszczak JanJaroszczak linked an issue May 7, 2024 that may be closed by this pull request
[BUG] Slow delegation issue #897
Closed
Sworzen1
Sworzen1 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Sworzen1 Sworzen1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3, merge if works

@JanJaroszczak JanJaroszczak merged commit b919a42 into develop May 7, 2024
3 of 4 checks passed
@JanJaroszczak JanJaroszczak deleted the 897-bug-slow-delegation-issue branch May 7, 2024 12:05
@JanJaroszczak JanJaroszczak linked an issue May 7, 2024 that may be closed by this pull request
DRep explorer - delegation to a DRep seems to fail but there is info that 'You have delegated A... to: with card and DRep id #875
Closed
This was referenced May 7, 2024
Closed
Closed
@pmbinapps pmbinapps mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JanJaroszczak @Sworzen1