-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Gujarati translation #307
Conversation
Hello @Darpana-iitgn could you please revert changes in |
This reverts commit 808f11d.
src/utils/translations/gu.ts
Outdated
Period: "માસિક", | ||
today: "આજે", | ||
Delay: "વિલંબ", | ||
Days: "(૦)[દિવસ];(૧)[દિવસ];(૨-૨)[દિવસ];(૫-૨૦)[દિવસ];(૨૧)[દિવસ];(૨૨-૨૪)[દિવસ];(૨૫-૩૦)[દિવસ];(૩૧)[દિવસ];(૩૨-૩૪)[દિવસ];(૩૫-૪૦)[દિવસ];", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are writing the same word in any case, so you just can use (0-inf)
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR didn't pass the formatter check. If it's not difficult, could you fix this, please? To do this, you can run
npm run fmt
Hello, @Darpana-iitgn! Thank you for your interest in the project! I looked at your translation and it seems to me that it is not quite correct. Unfortunately, I don't know Gujarati, so I used the ChatGPT to check, and it suggested a slightly different version. For example, ChatGPT translated the phrase "Period in 10 days" as "10 દિવસમાં માસિક આવશે", and in your version "માસિક ધારામાં 10 દિવસ" it seems to have a slightly different meaning - more about period that last 10 days, and not that it will start in 10 days. Here is screenshot that the chat showed: Maybe the chat is wrong? Could you carefully check the translation again? Thanks! |
Hi @IraSoro, I had misinterpreted the code earlier and have now corrected this line. The suggestion by ChatGPT is correct, but we can also translate "Period in 10 days" as "માસિક ધારા 10 દિવસમાં", which is what I have changed the code to. I have checked other translations once again and they seem correct to me, but pls let me know if I have missed anything else. I ran "npm run fmt", but it is causing changes in various files so I didnt commit it. |
@Darpana-iitgn, I checked again and found the following errors: I have a question, are you a native speaker? Because for me, as a non-native speaker, the translation doesn't look quite correct. It loses the context of the topic, mistakes in the description of menstruation and other errors caused by either typos or automatic translation. |
@Darpana-iitgn, thanks for replying to the comment and correcting the errors! Congratulations on your first contribution to |
Added Gujarati translation as part of issue #279