Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gujarati translation #307

Merged
merged 9 commits into from
Oct 20, 2024
Merged

Added Gujarati translation #307

merged 9 commits into from
Oct 20, 2024

Conversation

Darpana-iitgn
Copy link

Added Gujarati translation as part of issue #279

@imblowfish
Copy link
Collaborator

Hello @Darpana-iitgn could you please revert changes in package.json and package-lock.json?

This reverts commit 808f11d.
Period: "માસિક",
today: "આજે",
Delay: "વિલંબ",
Days: "(૦)[દિવસ];(૧)[દિવસ];(૨-૨)[દિવસ];(૫-૨૦)[દિવસ];(૨૧)[દિવસ];(૨૨-૨૪)[દિવસ];(૨૫-૩૦)[દિવસ];(૩૧)[દિવસ];(૩૨-૩૪)[દિવસ];(૩૫-૪૦)[દિવસ];",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are writing the same word in any case, so you just can use (0-inf) instead

imblowfish
imblowfish previously approved these changes Oct 10, 2024
@imblowfish imblowfish added this to the vNext milestone Oct 10, 2024
@IraSoro IraSoro linked an issue Oct 14, 2024 that may be closed by this pull request
Copy link
Owner

@IraSoro IraSoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR didn't pass the formatter check. If it's not difficult, could you fix this, please? To do this, you can run

npm run fmt

@IraSoro
Copy link
Owner

IraSoro commented Oct 14, 2024

Hello, @Darpana-iitgn! Thank you for your interest in the project!

I looked at your translation and it seems to me that it is not quite correct. Unfortunately, I don't know Gujarati, so I used the ChatGPT to check, and it suggested a slightly different version.

For example, ChatGPT translated the phrase "Period in 10 days" as "10 દિવસમાં માસિક આવશે", and in your version "માસિક ધારામાં 10 દિવસ" it seems to have a slightly different meaning - more about period that last 10 days, and not that it will start in 10 days. Here is screenshot that the chat showed:
{2F25A257-D4A8-4705-A96E-E869C18F10C4}
There are also other comments on the translation.

Maybe the chat is wrong? Could you carefully check the translation again?

Thanks!

@Darpana-iitgn
Copy link
Author

Hi @IraSoro, I had misinterpreted the code earlier and have now corrected this line. The suggestion by ChatGPT is correct, but we can also translate "Period in 10 days" as "માસિક ધારા 10 દિવસમાં", which is what I have changed the code to. I have checked other translations once again and they seem correct to me, but pls let me know if I have missed anything else. I ran "npm run fmt", but it is causing changes in various files so I didnt commit it.

@IraSoro IraSoro self-requested a review October 17, 2024 08:12
@IraSoro
Copy link
Owner

IraSoro commented Oct 17, 2024

@Darpana-iitgn, I checked again and found the following errors:
{99B7180B-342F-4BB5-8867-268E89EF7A9D}

{2C298049-BBE7-4C1D-A203-386AD143375B}

image

I have a question, are you a native speaker? Because for me, as a non-native speaker, the translation doesn't look quite correct. It loses the context of the topic, mistakes in the description of menstruation and other errors caused by either typos or automatic translation.

@Darpana-iitgn
Copy link
Author

Hi, I am a native speaker and have done all the translations myself. ChatGPT is not an extremely reliable source to check since it gives varying suggestions to all users, which might not necessarily be always correct. In the first 2 pictures you have shown, native speakers would consider both the sentences be the same in meaning, since sometimes similar sentences can have the same translation in english. 3rd error was a spelling mistake.

Still, I have changed my code to the version ChatGPT recommends and have checked it too.
image

@IraSoro IraSoro merged commit b15ce48 into IraSoro:master Oct 20, 2024
1 check passed
@IraSoro
Copy link
Owner

IraSoro commented Oct 20, 2024

@Darpana-iitgn, thanks for replying to the comment and correcting the errors!

Congratulations on your first contribution to Peri! And thanks for translating to Gujarati!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hacktoberfest: Add translation
4 participants