Update default fcrepo URL for Hypercube to use port 8080 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelgbanks
approved these changes
Nov 18, 2022
ruebot
reviewed
Nov 19, 2022
| @@ -29,7 +29,7 @@ RUN --mount=type=cache,id=hypercube-apk,sharing=locked,from=cache,target=/var/ca | |||
| addgroup nginx jwt && \ | |||
| cleanup.sh | |||
|
|
|||
| ENV HYPERCUBE_FCREPO_URL=fcrepo/fcrepo/rest \ | |||
| ENV HYPERCUBE_FCREPO_URL=fcrepo:8008/fcrepo/rest \ | |||
There was a problem hiding this comment.
I've taken the liberty to straight push that fix: b3e273a
Sorry for the derp.
There was a problem hiding this comment.
Wouldn't break it either way, since it's not used for anything other than the configuration parser expects some value to be present. Nonetheless best that it's correct :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues/2190.
I guess we missed this default when removing the nginx proxy from the fedora container? 🤷 Not sure why this didn't manifest sooner, but it's easily fixable.