Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default fcrepo URL for Hypercube to use port 8080 #266

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Update default fcrepo URL for Hypercube to use port 8080 #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800074a
Update README.md
dannylamb Nov 18, 2022
9b9b7b9
Update Dockerfile
dannylamb Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hypercube/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RUN --mount=type=cache,id=hypercube-apk,sharing=locked,from=cache,target=/var/ca
addgroup nginx jwt && \
cleanup.sh

ENV HYPERCUBE_FCREPO_URL=fcrepo/fcrepo/rest \
ENV HYPERCUBE_FCREPO_URL=fcrepo:8008/fcrepo/rest \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8008 or 8080?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty to straight push that fix: b3e273a

Sorry for the derp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't break it either way, since it's not used for anything other than the configuration parser expects some value to be present. Nonetheless best that it's correct :)

HYPERCUBE_LOG_LEVEL=info

COPY --from=crayfish /etc/nginx/http.d/default.conf /etc/nginx/http.d/default.conf
Expand Down
2 changes: 1 addition & 1 deletion hypercube/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ additional settings, volumes, ports, etc.

| Environment Variable | Confd Key | Default | Description |
| :------------------- | :-------------------- | :----------------- | :------------------------------------------------------------------------------------------------ |
| HYPERCUBE_FCREPO_URL | /hypercube/fcrepo/url | fcrepo/fcrepo/rest | Fcrepo Rest API URL |
| HYPERCUBE_FCREPO_URL | /hypercube/fcrepo/url | fcrepo:8080/fcrepo/rest | Fcrepo Rest API URL |
| HYPERCUBE_LOG_LEVEL | /hypercube/log/level | debug | Log level. Possible Values: debug, info, notice, warning, error, critical, alert, emergency, none |

[Hypercube]: https://github.com/Islandora/Crayfish/tree/main/Hypercube