Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[Refactor] AccountsViewModel: use by delegation for mutable states #3520

Closed
1 task done
shamim-emon opened this issue Sep 16, 2024 · 5 comments · Fixed by #3525
Closed
1 task done

[Refactor] AccountsViewModel: use by delegation for mutable states #3520

shamim-emon opened this issue Sep 16, 2024 · 5 comments · Fixed by #3525
Assignees
Labels
approved Approved by the Ivy Wallet team. Ready for dev good first issue Good for newcomers

Comments

@shamim-emon
Copy link
Member

shamim-emon commented Sep 16, 2024

Please confirm the following

What would you like to improve?

Rework val x = mutableStateOf() and x.value to x by mutableStateOf() and x.

Because...
It's more convenient to use and the code becomes simpler to read.

Description
No response

Success Criteria
No functional changes
The app works as expected

@shamim-emon shamim-emon added the good first issue Good for newcomers label Sep 16, 2024
@ivywallet
Copy link
Collaborator

Thank you @shamim-emon for raising Issue #3520! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

@prathmeshkc
Copy link
Contributor

I'm on it

@ivywallet
Copy link
Collaborator

⚠️ Hey @prathmeshkc, this issue is not approved, yet.
@ILIYANGERMANOV must approve it first.

Also, make sure to read our Contribution Guidelines.

@ILIYANGERMANOV ILIYANGERMANOV added the approved Approved by the Ivy Wallet team. Ready for dev label Sep 16, 2024
@shamim-emon
Copy link
Member Author

I'm on it

@ivywallet
Copy link
Collaborator

Thank you for your interest @shamim-emon! 🎉
Issue #3520 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Approved by the Ivy Wallet team. Ready for dev good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants