Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

[Refactor] AccountsViewModel: using by delegation for mutable states #3525

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Sep 16, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've updated AccountsViewModel as such that all it's mutableStates uses by delegate

Risk factors

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV ILIYANGERMANOV added the ready to merge 🚀 PR can be merged after the CI pass label Sep 16, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 7fbb143 into Ivy-Apps:main Sep 16, 2024
9 checks passed
@shamim-emon shamim-emon deleted the fix-issue-3520 branch September 16, 2024 10:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready to merge 🚀 PR can be merged after the CI pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] AccountsViewModel: use by delegation for mutable states
2 participants