Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Different decimal place for crypto and fiat currency #3324

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

suyash01
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

What's changed?

Describe with a few bullets what's new:

  • Updated to use different decimal place for crypto and fiat currency
Before After

Risk factors

What may go wrong if we merge your PR?

  • Exchange rate wrapping may happen for small screen

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues?

Troubleshooting CI failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few comments

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Jul 10, 2024
@ILIYANGERMANOV
Copy link
Collaborator

@suyash01 can you test if the Amount input keyboard works with crypto? I'd appreciate a screen recording where you make a crypto transaction

@suyash01
Copy link
Contributor Author

recording1.mp4

@ILIYANGERMANOV seems to be working fine with crypto as both to and from

@ILIYANGERMANOV ILIYANGERMANOV merged commit 6cc2f09 into Ivy-Apps:main Jul 10, 2024
8 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 4 decimal is not enough for crypto
2 participants