Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes decimal place in amount input sheet #3334

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

suyash01
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

What's changed?

Describe with a few bullets what's new:

  • Dynamic decimal place for amount input sheet
    • 2 decimal for fiat currency
    • 18 decimal for crypto
Before After

Risk factors

What may go wrong if we merge your PR?

  • There will be wrapping for crypto exchange rates on small screens

In what cases won't your code work?

  • ...

Does this PR close any GitHub issues?

Troubleshooting CI failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

@ILIYANGERMANOV ILIYANGERMANOV merged commit 2c38ca5 into Ivy-Apps:main Jul 11, 2024
8 checks passed
@ILIYANGERMANOV
Copy link
Collaborator

@suyash01 off-topic, do you have any tips for improving the PR template for the description?

@suyash01
Copy link
Contributor Author

@suyash01 off-topic, do you have any tips for improving the PR template for the description?

The current template is very well defined, I cant think of anything to change. Maybe CodingGeo have something in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 4 decimal is not enough for crypto
2 participants