Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed invalid timestamp for transactions with unedited date or time #3390

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

suyash01
Copy link
Contributor

@suyash01 suyash01 commented Aug 3, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

ivy-wallet-3327.mp4

What's changed?

Describe with a few bullets what's new:

  • Fixed timstamp for transactions for which user were relying on default selection
  • Fixed transactions fetch range
Before After
{media} {media}
{media} {media}

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but let's give it a shot, the changes seem to make sense

@suyash01
Copy link
Contributor Author

suyash01 commented Aug 3, 2024

Haven't tested it but let's give it a shot, the changes seem to make sense

It atleast fixes the timeline issue people are facing on the home screen. Should also fix the balance issue on account page.

@ILIYANGERMANOV
Copy link
Collaborator

There seems to be a problem with the Integration Tests workflow. We can merge without out. Can you open an issue for the Integration Tests so we can fix it?

@ILIYANGERMANOV ILIYANGERMANOV merged commit 67dbe66 into Ivy-Apps:main Aug 3, 2024
8 of 9 checks passed
This was referenced Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions don't be reflected in the amount until time edited
2 participants