Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Save internal with timeNowUTC to get correct dateTime #3401

Closed
wants to merge 2 commits into from

Conversation

rodrigoliveirac
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed the current dateTime transaction record
Before After
Screenshot 2024-08-06 at 09 13 12 Screenshot 2024-08-06 at 09 13 37
Before After
Alt text Alt text

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@ILIYANGERMANOV
Copy link
Collaborator

@rafaeltonholo is the record time correct? I mean when you create a new transaction and check its time

@rodrigoliveirac
Copy link
Contributor Author

@ILIYANGERMANOV The record time is correct but incomplete. This is because timeNowLocal() does not account for the time zone, while timeNowUTC() does.

@rafaeltonholo is the record time correct? I mean when you create a new transaction and check its time

The record time is correct, but incomplete. This is because timeNowLocal() does not account for the time zone, while timeNowUTC() does

@rodrigoliveirac
Copy link
Contributor Author

rodrigoliveirac commented Aug 6, 2024

@ILIYANGERMANOV @suyash01 I've just noticed that these changes were already made in #3390.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with balance when added income/expense
2 participants