Updates required for creating binary (build) caches #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ack-stack into feature/buildcaches
climbfuji
requested review from
ulmononian,
mark-a-potts,
srherbener and
AlexanderRichert-NOAA
srherbener
approved these changes
Feb 24, 2023
AlexanderRichert-NOAA
approved these changes
Feb 24, 2023
climbfuji
force-pushed
the
feature/buildcaches
branch
from
4475590
to
e1dea40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the submodule pointer for spack with changes required for creating binary (build) caches for multiple packages, for example all packages in an environment, at once. See JCSDA/spack#231 for a description of the changes.
I also added a config option in
configs/common/config.yamlthat must be enabled when creating build caches. It is not enabled by default, because the option should only be used when creating build caches. It basically pads the library path in shared libraries with "garbage" so that a package can later be relocated to a path that is longer than the one it was built for. In future PRs, we will provide the necessary documentation and automation to enable this option when creating build caches.This PR is also needed to fix the CI tests in following PRs (see #476 for macOS, Linux will be contributed by EPIC using Jenkins, plus possible other solutions).
Issues
Working towards #365
Dependencies
Waiting on JCSDA/spack#231