-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates required for creating binary (build) caches #231
Updates required for creating binary (build) caches #231
Conversation
…/buildcache.py to enable building build caches for multiple packages without aborting after failures
… recursive symlink in source code after installation
…pack into feature/buildcaches
684e5c4
to
7ed0fc6
Compare
The CI test failure doesn't look like it is related to this PR (https://github.com/NOAA-EMC/spack/actions/runs/4263344812/jobs/7419969492):
I think this PR is ready to go! |
Ah, and rerunning it fixed it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be very nice to have this improved build cache feature. approved.
Description
These updates are required for creating build caches for all packages in an environment by skipping packages with errors instead of aborting, which is what spack does at the moment. I created a corresponding issue and PR in the upstream spack repo: spack#35602 and spack#35601.
Note that the changes differ slightly from this PR due to the updates that went into spack develop in these files. I will take care of resolving the conflicts when we bring these changes down to our fork).
Testing
Tested successfully on my macOS. See JCSDA/spack-stack#484 for the corresponding spack-stack PR.