Bug fix for mapl when environment variable BASEDIR is set #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mathomp4
reviewed
Feb 17, 2023
| # for an environment variable with the same name. This | ||
| # name is common and used all over the place, and if | ||
| # it is set it breaks the mapl build. Unset it here ... | ||
| env.unset("BASEDIR") |
There was a problem hiding this comment.
Oops. Sorry about this, @climbfuji. I added that code because users here didn't want to always pass in -DBASEDIR on the CMake line. I don't mind doing it, but users liked being able to do cmake -B build and all works.
There was a problem hiding this comment.
Not a problem at all, just wondering if we could use a safer name going forward, for example GEOS_BASEDIR or something like that?
There was a problem hiding this comment.
Well, if/when we go to Spack, we won't need it, so that's nice. Unfortunately, BASEDIR is pretty much embedded into the foundations of GEOS. Build system, run script, etc.
…pack into feature/mapl_basedir_buildcache_macos
climbfuji
changed the title
AlexanderRichert-NOAA
approved these changes
Feb 24, 2023
…pack into feature/mapl_basedir_buildcache_macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a problem with
maplwhere the presence of the environment variableBASEDIRwrecks havoc for the build of the package. This environment variable isn't needed when using spack to buildmapland other GEOS packages. It's only needed when using the oldbaselibssystem developed by NASA.Tested with JCSDA/spack-stack#476.