forked from spack/spack
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for mapl when environment variable BASEDIR is set #229
Merged
climbfuji
merged 6 commits into
JCSDA:jcsda_emc_spack_stack
from
climbfuji:feature/mapl_basedir_buildcache_macos
Feb 25, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f9ed0a4
Bug fix for duplicate rpath errors on macOS when creating build cache…
climbfuji 022e369
Merge branch 'jcsda_emc_spack_stack' of https://github.com/NOAA-EMC/s…
climbfuji eabe9b6
Bug fix in mapl: unset environment variable BASEDIR
climbfuji e2b7e7f
Merge branch 'jcsda_emc_spack_stack' of https://github.com/NOAA-EMC/s…
climbfuji 691469b
Update comment in var/spack/repos/builtin/packages/mapl/package.py
climbfuji ba727e8
Merge branch 'jcsda_emc_spack_stack' of https://github.com/NOAA-EMC/s…
climbfuji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Sorry about this, @climbfuji. I added that code because users here didn't want to always pass in
-DBASEDIR
on the CMake line. I don't mind doing it, but users liked being able to docmake -B build
and all works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem at all, just wondering if we could use a safer name going forward, for example GEOS_BASEDIR or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if/when we go to Spack, we won't need it, so that's nice. Unfortunately,
BASEDIR
is pretty much embedded into the foundations of GEOS. Build system, run script, etc.