This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
Master pedal #19
Merged
Master pedal #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add in tuning from hanabi95's fork * Update Panda ref * Pull in some increased temperature values from 7.7 Hopefully allows more usage in hot summer weather. * Re-enable cruise cancel and gas/brake cancel. Note: Gas cancel will lead to a mismatch, might need to think about a better solution here. * Revert "Re-enable cruise cancel and gas/brake cancel." This reverts commit b524a2d. * Update tuning pids to use INDI * Enable cruise buttons and gas/brake cancel Will require some troubleshooting to make sure it's functioning correctly. Possibility of state mismatch between panda and openpilot * Update panda * Update to account for possibility of missing attribute
* Add in tuning from hanabi95's fork * Update Panda ref * Pull in some increased temperature values from 7.7 Hopefully allows more usage in hot summer weather. * Re-enable cruise cancel and gas/brake cancel. Note: Gas cancel will lead to a mismatch, might need to think about a better solution here. * Revert "Re-enable cruise cancel and gas/brake cancel." This reverts commit b524a2d. * Update tuning pids to use INDI * Enable cruise buttons and gas/brake cancel Will require some troubleshooting to make sure it's functioning correctly. Possibility of state mismatch between panda and openpilot * Update panda * Update to account for possibility of missing attribute * Update tuning parameters based on real-world tuning Much better than before, still needs some work. Solid on turns mostly, and some jitter on straightaways. Sometimes a little oversteer that needs to be resolved. * Updated tuning, further drive tuning Better performance, less oscillation on straightaways, but needs more work. * Try alternate method of determining if pedal exists. * Assuming self.CP is the CarParams object, should be able to determine pedal
* Add in tuning from hanabi95's fork * Update Panda ref * Pull in some increased temperature values from 7.7 Hopefully allows more usage in hot summer weather. * Re-enable cruise cancel and gas/brake cancel. Note: Gas cancel will lead to a mismatch, might need to think about a better solution here. * Revert "Re-enable cruise cancel and gas/brake cancel." This reverts commit b524a2d. * Update tuning pids to use INDI * Enable cruise buttons and gas/brake cancel Will require some troubleshooting to make sure it's functioning correctly. Possibility of state mismatch between panda and openpilot * Update panda * Update to account for possibility of missing attribute * Update tuning parameters based on real-world tuning Much better than before, still needs some work. Solid on turns mostly, and some jitter on straightaways. Sometimes a little oversteer that needs to be resolved. * Updated tuning, further drive tuning Better performance, less oscillation on straightaways, but needs more work. * Try alternate method of determining if pedal exists. * Assuming self.CP is the CarParams object, should be able to determine pedal * Further refinement of INDI tuning values Almost completely rid of oscillation on straightaways, barely noticeable. May need some slight additional gain for really good cornering, will tune more as I have time. * Further improvements on lateral tuning
JMPZ11
added a commit
that referenced
this pull request
Oct 11, 2020
bd9a877 pulse desire and e2e 20c7fd6 Add subaru pre-Global safety mode 522ff85 Merge pull request commaai#31 from commaai/good_location_packet ab07f22 deprecate b03c2c5 already exists 166418c improvements 97373f9 or rigor in american 365abba rigour 25eaf9d add espDisabled to carState (#30) bb13121 add honda ecus (#29) eba4349 put liveLocation in qlogs 6c4735f add fixed fingerprintSource 4c50d26 GitHub actions (#25) 988783f Merge pull request #28 from commaai/power_monitoring b43fd06 Added offroad power usage ab32956 Merge pull request #27 from commaai/ublox-hw-status 2e7f4b9 Added ublox hw status 23abef4 add networkType to thermal 3f01dcf fix bad naming 4999e62 unconfusing and accessible to all 8f9aa8f add fingerprintSource to carParams 5794030 better put 06f8d15 standalone monitorstate (#23) 6eb1e36 qlog at model rate c38fb57 LateralParams 0c45f20 add uncertainty event name 01942b8 add TODO b74a456 don't hardcode the lists ed5a4bf add face stds 396a2bb add can error counter to controlsState c6b5c73 Switch default to msgq (#21) a457ffa Fix indentation in readme.md a1fc8c7 explicitly mention Python for syntax colouring (#20) 19e2393 Fix expected for cameraOdometry and liveCalibration e7d2f97 Add radar comm issue error db64cd4 Reserve safety #21 for VAG PQ35/PQ46/NMS (#19) 79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec 2614a65 better name b6b84cd add longitudinal 78f5934 Add canRxErrs to health 6758899 qlog liveCalibration df80b87 add more stuff to fw log in CarParams a87805a fix doxs 4746b20 got doxed 21cf3f5 build on mac 31ac47c Add carUnrecognized event b8382bb steerLimitTimer should be car dependent 9a22968 add pa0 temp to ThermalData f6f0f60 Add stock Fcw to carState b608683 no l/r distinction for LDW 555f48d Add ldw alert 8e8b4a4 Remove plusFrame socket in favor of UiLayoutState 3410325 log stock AEB events 2219f2b Add warning about not using cython version of sec_since_boot 8f1a512 for legacy-testing reasons, better to define the used percent instead of avail e86d954 adding low memory event ad23834 remove TODO d0962b3 log mem available and cpu perc in thermald 3b753be Implement error handling and exceptions (#18) a7d5bb7 add explicit dependencies on services.h 1ba6467 fix linter c7d215b Added communityFeatureDisallowed event 492140a Added communityFeature bit detection to CarParams 266a5fe log Panda fault types 347a866 Switch from polling on FIFOs to signal (#12) e25bba7 no need to double build the objects fe43a99 20Hz for radar time step is very standard 2aabf1e Added radar time step to car params e8ae908 Generate capnp for java 57126a2 cereal_shared da655cd Add uptime to health f6a8e39 add test with multiple subscribers 84b3af5 comment out the debugging 4b9c942 added power save state to health packet 66be370 run python unittest in ci 52c6db8 Run scons in CI (#14) 9414615 do need it, but only for arm 2856c37 remove gnustl_shared 7f05ee6 fix apks e3a6bde Revert "no more makefiles" 487fbd0 don't rely on BASEDIR, and add zmq library 223e37a no more makefiles da2ed11 don't link the wrong one fe9fe2a scons builds the python lib now 2f81135 err, it can't build services.h 57b03f8 now we shouldn't need that yaml crap everywhere f8e5327 bridge builds with services.h 2b0cb60 noOutput safety mode is now called silent 83880d5 add msgq tests bcad184 msgq: dont block when fifo does not exists b4b2678 Default to zmq 473e291 fix compilation in docker 30aaadd msgq: try again when no timeout on poll but also no message c4f2ad5 msgq: make sure read_fifos is initalized so we dont close random fds 4e513a8 msgq: dont clean up uninitialized sockerts c008b63 also remove the fifo from disk ef64eb2 MSGQ stability improvements when opening and closing lots of queues e147abc Revert "Revert "deprecate irpwr"" 932dc32 Revert "deprecate irpwr" a684415 disengage ec27e18 capnpc also generated the header files ee52ab9 deprecate irpwr 301c74c Merge branch 'master' of github.com:commaai/cereal 6da7d55 add front frame a5944eb add conflate parameter for SubSocket::create ca8df17 Add fault status to health ef4ded0 add conflate support in SubSocket constructor 7fd314a update scons build file 93d814e add saturated flags to indi and lqr logs 50302fe add steeringRateLimited to car.capnp 05e3513 add msgq readme a6759a9 faster make 94b7377 Add struct to log FW version 64ce0b5 add scons build dc9ad18 add debug print statement on SIGINT 4a61269 Merge pull request #10 from commaai/msgq 4873449 use recv one or none after poll a054864 default to msgq fbc4a4c oops bad number 5067cf4 add meta cbd0286 fix export prefix and make shared library world readable c273054 add c exports for jni usage e77f41e zmq already sets the errno correctly 3196cf6 Fix service list path in bridge d35515a add all msgq files, but dont use as default a68a38f Don't delete context from python side only bd46c22 Revert "zmq_ctx_term is blocking" a1fc26b zmq_ctx_term is blocking 0902182 remote address support 21a3536 only delete subsocket when created by same object 34df735 remove extra underscore from __dealloc__ c8748f8 fix internal refs 79b2fbf fixups 23ad256 import messaging and services git-subtree-dir: cereal git-subtree-split: bd9a877
JMPZ11
added a commit
that referenced
this pull request
Oct 11, 2020
bd9a877 pulse desire and e2e 20c7fd6 Add subaru pre-Global safety mode 522ff85 Merge pull request commaai#31 from commaai/good_location_packet ab07f22 deprecate b03c2c5 already exists 166418c0 improvements 97373f9 or rigor in american 365abba rigour 25eaf9d add espDisabled to carState (#30) bb13121 add honda ecus (#29) eba4349 put liveLocation in qlogs 6c4735f add fixed fingerprintSource 4c50d26 GitHub actions (#25) 988783f Merge pull request #28 from commaai/power_monitoring b43fd06 Added offroad power usage ab32956 Merge pull request #27 from commaai/ublox-hw-status 2e7f4b9 Added ublox hw status 23abef4 add networkType to thermal 3f01dcf fix bad naming 4999e62 unconfusing and accessible to all 8f9aa8f add fingerprintSource to carParams 5794030 better put 06f8d15 standalone monitorstate (#23) 6eb1e36 qlog at model rate c38fb57 LateralParams 0c45f20 add uncertainty event name 01942b8 add TODO b74a456 don't hardcode the lists ed5a4bf add face stds 396a2bb add can error counter to controlsState c6b5c73 Switch default to msgq (#21) a457ffa Fix indentation in readme.md a1fc8c7 explicitly mention Python for syntax colouring (#20) 19e2393 Fix expected for cameraOdometry and liveCalibration e7d2f97 Add radar comm issue error db64cd4 Reserve safety #21 for VAG PQ35/PQ46/NMS (#19) 79d638d separate honda safety models between Bosch Giraffe and Bosch Nidec 2614a65 better name b6b84cd add longitudinal 78f5934 Add canRxErrs to health 6758899 qlog liveCalibration df80b87 add more stuff to fw log in CarParams a87805a fix doxs 4746b20 got doxed 21cf3f5 build on mac 31ac47c Add carUnrecognized event b8382bb steerLimitTimer should be car dependent 9a22968 add pa0 temp to ThermalData f6f0f60 Add stock Fcw to carState b608683 no l/r distinction for LDW 555f48d Add ldw alert 8e8b4a4 Remove plusFrame socket in favor of UiLayoutState 3410325 log stock AEB events 2219f2b Add warning about not using cython version of sec_since_boot 8f1a512 for legacy-testing reasons, better to define the used percent instead of avail e86d954 adding low memory event ad23834 remove TODO d0962b3 log mem available and cpu perc in thermald 3b753be Implement error handling and exceptions (#18) a7d5bb7 add explicit dependencies on services.h 1ba6467 fix linter c7d215b Added communityFeatureDisallowed event 492140a Added communityFeature bit detection to CarParams 266a5fe log Panda fault types 347a866 Switch from polling on FIFOs to signal (#12) e25bba7 no need to double build the objects fe43a99 20Hz for radar time step is very standard 2aabf1e Added radar time step to car params e8ae908 Generate capnp for java 57126a2 cereal_shared da655cd Add uptime to health f6a8e39 add test with multiple subscribers 84b3af5 comment out the debugging 4b9c942 added power save state to health packet 66be370 run python unittest in ci 52c6db8 Run scons in CI (#14) 9414615 do need it, but only for arm 2856c37 remove gnustl_shared 7f05ee6 fix apks e3a6bde Revert "no more makefiles" 487fbd0 don't rely on BASEDIR, and add zmq library 223e37a no more makefiles da2ed11 don't link the wrong one fe9fe2a scons builds the python lib now 2f81135 err, it can't build services.h 57b03f8 now we shouldn't need that yaml crap everywhere f8e5327 bridge builds with services.h 2b0cb60 noOutput safety mode is now called silent 83880d5 add msgq tests bcad184 msgq: dont block when fifo does not exists b4b26782 Default to zmq 473e291 fix compilation in docker 30aaadd msgq: try again when no timeout on poll but also no message c4f2ad5 msgq: make sure read_fifos is initalized so we dont close random fds 4e513a85 msgq: dont clean up uninitialized sockerts c008b63 also remove the fifo from disk ef64eb2 MSGQ stability improvements when opening and closing lots of queues e147abc Revert "Revert "deprecate irpwr"" 932dc32 Revert "deprecate irpwr" a684415 disengage ec27e18 capnpc also generated the header files ee52ab9 deprecate irpwr 301c74c8 Merge branch 'master' of github.com:commaai/cereal 6da7d55 add front frame a5944eb add conflate parameter for SubSocket::create ca8df17 Add fault status to health ef4ded0 add conflate support in SubSocket constructor 7fd314a update scons build file 93d814e add saturated flags to indi and lqr logs 50302fe add steeringRateLimited to car.capnp 05e3513 add msgq readme a6759a9 faster make 94b7377 Add struct to log FW version 64ce0b5 add scons build dc9ad18 add debug print statement on SIGINT 4a61269 Merge pull request #10 from commaai/msgq 4873449 use recv one or none after poll a054864 default to msgq fbc4a4c oops bad number 5067cf4 add meta cbd0286 fix export prefix and make shared library world readable c273054 add c exports for jni usage e77f41e zmq already sets the errno correctly 3196cf6 Fix service list path in bridge d35515a add all msgq files, but dont use as default a68a38f Don't delete context from python side only bd46c22 Revert "zmq_ctx_term is blocking" a1fc26b zmq_ctx_term is blocking 0902182 remote address support 21a3536 only delete subsocket when created by same object 34df735 remove extra underscore from __dealloc__ c8748f8 fix internal refs 79b2fbf fixups 23ad256 import messaging and services git-subtree-dir: cereal git-subtree-split: bd9a877
darknight111
pushed a commit
to darknight111/openpilot
that referenced
this pull request
Dec 14, 2021
…83-develop fix readme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding: