-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hang when exporting at the CLI #10383
Conversation
- pass RemotePreferences to handleMultipleAppInstances - Introduce separate call to processArguments() - Add test case convertBibtexToTablerefsabsbib
private final List<ParserResult> parserResults; | ||
|
||
// Written once by processArguments() | ||
private List<ParserResult> parserResults; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
init with empty list?
looks good so far, but would need testing with the binary. |
Test was done at #10380 (comment). I wonder whether we could simply do |
I tried it with |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
the 60s shutdown is normally only the timeout if the tasks were not shutdown before: jabref/src/main/java/org/jabref/gui/Globals.java Lines 118 to 130 in a0e2564
|
* upstream/main: update javafx to 20.0.2 [Bot] Update journal abbreviation lists (JabRef#10387) Fix hang when exporting at the CLI (JabRef#10383) Add tests for EntryComperatorTest (JabRef#10357) Update CSL styles Remove empty lines One more Refinements Update docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-89-run-with-intellij.md Add some more exports Refine IntelliJ howto Fix localization Adds LaTeX integrity check based on SnuggleTeX Fix casing "macOS" and "JabRef", vendor: JabRef e.V.
Fixes #10380
There were two issues:
The former was solved by using the right getter (
e4ea759
(#10383)), the latter was solved by shutting down the file update monitor18a3cd3
(#10383) (refs https://github.com/JabRef/jabref-issue-melting-pot/issues/290).Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)