Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bot] Update journal abbreviation lists #10387

Merged
merged 10 commits into from
Sep 16, 2023
Merged

[Bot] Update journal abbreviation lists #10387

merged 10 commits into from
Sep 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@koppor
Copy link
Member

koppor commented Sep 16, 2023

This PR has the correct diff:

image

These are the two most recent commits in https://github.com/JabRef/abbrv.jabref.org/commits/main

@koppor koppor mentioned this pull request Sep 16, 2023
6 tasks
@Siedlerchr
Copy link
Member

failed to create review: GraphQL: Can not approve your own pull request (addPullRequestReview)

Siedlerchr
Siedlerchr previously approved these changes Sep 16, 2023
@koppor
Copy link
Member

koppor commented Sep 16, 2023

failed to create review: GraphQL: Can not approve your own pull request (addPullRequestReview)

I am working on this. 😅

jabref-machine
jabref-machine previously approved these changes Sep 16, 2023
@github-actions github-actions bot enabled auto-merge September 16, 2023 09:15
@koppor
Copy link
Member

koppor commented Sep 16, 2023

More on the bot usage - and alternatives:

https://github.com/peter-evans/create-pull-request/blob/main/docs/concepts-guidelines.md#triggering-further-workflow-runs

I opted for the machine-way, but I "just" added a token for approval there to avoid a fork of the JabRef repo.

jabref-machine
jabref-machine previously approved these changes Sep 16, 2023
@github-actions github-actions bot enabled auto-merge September 16, 2023 09:33
@koppor
Copy link
Member

koppor commented Sep 16, 2023

I changed the condition to trigger only on https://github.com/JabRef/jabref to avoid errors on forks (e.g., JabRef#656 would be auto-approved, but the GH_TOKEN_JABREF_MACHINE_ is not available there)

@github-actions github-actions bot added this pull request to the merge queue Sep 16, 2023
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 16, 2023

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 16, 2023
@koppor koppor added this pull request to the merge queue Sep 16, 2023
Merged via the queue into main with commit 2760070 Sep 16, 2023
14 checks passed
@koppor koppor deleted the update-journal-lists branch September 16, 2023 12:09
Siedlerchr added a commit to Jaovitosr/jabref that referenced this pull request Sep 18, 2023
* upstream/main:
  update javafx to 20.0.2
  [Bot] Update journal abbreviation lists (JabRef#10387)
  Fix hang when exporting at the CLI (JabRef#10383)
  Add tests for EntryComperatorTest (JabRef#10357)
  Update CSL styles
  Remove empty lines
  One more
  Refinements
  Update docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-89-run-with-intellij.md
  Add some more exports
  Refine IntelliJ howto
  Fix localization
  Adds LaTeX integrity check based on SnuggleTeX
  Fix casing "macOS" and "JabRef", vendor: JabRef e.V.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants