Fix column sort order gets overwritten

[Siedlerchr]

Fixes #7524

The problem was that mainTable.getSortOrder is only filled when there is a change. However, updateColumnPreferences was also called when just the width changed and then getSortOrder was empty and was always overwritten.

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[calixtus]

May i eventually push on your branch? I'd prefer immutable preferences objects...

[calixtus]

Fix itself looks right. But there are some code style things I would like to change.

[Siedlerchr]

@calixtus Sure, but I think the root cause was the immutable ColumnPreferences, the sort order was always overwritten even if it did not change. Note that it is also not possible to check for empty, because when you clear the sort order the list is empty and you could not reset the sort order.

[calixtus]

I think it's fine. I just made the ColumnPreferences immutable again, but kept the distinction in the methods between updates of the SortOrder and the Columns, so nothing should be overwritten. It just pulls the old opposite unchanged value directly from the preferences. The logic should be exactly the same, but without altering the existing ColumnPreferences, but creating new ones with the kept value from the preferences.

Can you please check it to be sure it works for you?
I just believe, this looks a bit cleaner.

[tobiasdiez]

Codewise LGTM!

[Siedlerchr]

Ah I see, will test tomorrow

[Siedlerchr]

Works, but I found another bug in the SaveOrderConfig.SortCriterion uses Boolean.parseBoolean() and it was passed the enum values "ASCENDING" or "DESCENDING" which obviously will always return false when you have that input for Boolean.parse

[koppor]

DevCall: Merge as hotfix; later: nice preferences (String should be enum)