Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some hints on test tooling #7585

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Add some hints on test tooling #7585

merged 2 commits into from
Mar 29, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 28, 2021

This was long in my email inbox. Since there is some testing activity, I thought it is a good thing to work on now.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

tobiasdiez
tobiasdiez requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!
I propose to move it further down though, so that the hands-on recommendations are still at the top.

docs/getting-into-the-code/code-howtos.md Outdated Show resolved Hide resolved
@Siedlerchr Siedlerchr merged commit 55c4467 into master Mar 29, 2021
@Siedlerchr Siedlerchr deleted the add-test-docs branch March 29, 2021 18:43
Siedlerchr added a commit that referenced this pull request Apr 9, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into writebackupToTemp
3a9c7db 
* upstream/main: (25 commits)
  Fix NumberFormatException in BracketedPattern (#7600)
  Update MAINTAINERS (#7601)
  Fix CSL update (#7592)
  Add unit tests for org.jabref.gui classes (#7579)
  Squashed 'buildres/csl/csl-styles/' changes from 30fb68e..e1acabe
  Bump tika-core from 1.25 to 1.26 (#7589)
  Revert "Skip Mac OS build if secret not present (#7591)" (#7594)
  Optimize saving (#7568)
  Skip Mac OS build if secret not present (#7591)
  Rename master to main in dev help
  Update tests-fetchers.yml
  Update refresh-journal-lists.yml
  Update deployment.yml
  Rename master to main in coding readme
  Rename master to main in citation style update
  Rename master to main in gitversion config
  Fix column sort order gets overwritten (#7573)
  Add some hints on test tooling (#7585)
  Add "Update Gradle Wrapper Action" (#7584)
  Bump classgraph from 4.8.102 to 4.8.104 (#7587)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

Assignees
No one assigned
Labels
[outdated] type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @tobiasdiez @Siedlerchr