Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM-Fetchers: Allow the search to return multiple entries. #8038

Merged
merged 1 commit into from
Aug 31, 2021
Merged

ACM-Fetchers: Allow the search to return multiple entries. #8038

merged 1 commit into from
Aug 31, 2021

Conversation

btut
Copy link
Contributor

@btut btut commented Aug 31, 2021

It's only important that the first one is the one we want.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Allow the search to return multiple entries.
d6c09f7 
It's only important that the first one is the one we want.
@btut btut self-assigned this Aug 31, 2021
@btut
Copy link
Contributor Author

btut commented Aug 31, 2021

Now IEEE fails (network error), but ACM is fine.

@Siedlerchr Siedlerchr merged commit 25f0c49 into JabRef:main Aug 31, 2021
Siedlerchr added a commit that referenced this pull request Aug 31, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into newGlobalSearch
715d068 
* upstream/main:
  Switch to archive.org for site.icu-project.org
  Add Java Profiler
  Fix output when closing JabRef while indexing (#8043)
  Remove explicit XMP import for PDFs (#8040)
  Fix crosses
  Stop indexing on cancel (#8039)
  Write embedded bib in addition to XMP metadata (#8037)
  Cleanup preferences (#8036)
  Fix Search dark mode theme (#8028)
  Allow the search to return multiple entries. (#8038)
  Refactored GroupTree.fxml to plain java (#8035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

@btut btut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btut @Siedlerchr