Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop fulltext-indexing on cancel #8039

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

btut
Copy link
Contributor

@btut btut commented Aug 31, 2021

When the user closes JabRef while indexing, a Dialog is shown asking whether to cancel the indexing. If the cancel is approved by the user, the indexing continued anyways. This is fixed with this PR.

Fixes JabRef#516

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@btut btut self-assigned this Aug 31, 2021
@btut btut added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 31, 2021
@Siedlerchr Siedlerchr merged commit 96a4bb0 into JabRef:main Aug 31, 2021
@btut btut deleted the fixIndexerCancel branch August 31, 2021 13:04
Siedlerchr added a commit that referenced this pull request Aug 31, 2021
* upstream/main:
  Switch to archive.org for site.icu-project.org
  Add Java Profiler
  Fix output when closing JabRef while indexing (#8043)
  Remove explicit XMP import for PDFs (#8040)
  Fix crosses
  Stop indexing on cancel (#8039)
  Write embedded bib in addition to XMP metadata (#8037)
  Cleanup preferences (#8036)
  Fix Search dark mode theme (#8028)
  Allow the search to return multiple entries. (#8038)
  Refactored GroupTree.fxml to plain java (#8035)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When cancelling indexinb background tasks, no exceptions should be shown
2 participants