Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open event log when clicking on collapsed notification #8837

Merged
merged 3 commits into from
May 22, 2022

Conversation

claell
Copy link
Contributor

@claell claell commented May 21, 2022

In #8775 (comment), I suggested a change for collapsed notifications to improve their UX. Since this has not been implemented there, I went ahead with my own approach.

The collapsed notifications contain a hint to the event log. However, for users, it is likely tiresome to find the menu entry and open the event log from there. Thus, when clicking the collapsed notification, the event log opens now.

Not sure, whether the way I did it is clean, so open for feedback.

An additional thing I noticed is that the event log is empty for me (not the case on the stable build). Probably not related, possibly, an issue should be created for it.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea very much. Maybe there should be also a check if the user really left-clicked on the messagebox to avoid unexpected side-effects.

…lick

* upstream/main:
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
  updated 8802 (JabRef#8817)
@Siedlerchr
Copy link
Member

@claell Thanks for the work! Looks good to me. The issue with the empty event log was fixed recently. Your fork was not yet up to date

@claell
Copy link
Contributor Author

claell commented May 21, 2022

I like this idea very much. Maybe there should be also a check if the user really left-clicked on the messagebox to avoid unexpected side-effects.

Good point, I'll check on that when I have time.

@Siedlerchr thanks for the hint with the empty log, I already feared that this was related to my not up to date fork.

@Siedlerchr
Copy link
Member

I would merge this in now to reduce the number of PRs. Works fine and we still can create a follow up PR.

@Siedlerchr Siedlerchr merged commit b9846d7 into JabRef:main May 22, 2022
Siedlerchr added a commit to fly-ing-fish/jabref that referenced this pull request May 22, 2022
…-masked-characters#8787

* upstream/main:
  Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828)
  Open event log when clicking on collapsed notification (JabRef#8837)
  Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821)
  Fix single identifier cannot be opened on click (JabRef#8838)
  Add Pubmed/Medline Query Transformer (JabRef#8818)
  adjust and add testcases for FileAnnotationViewModel (JabRef#8830)
  Append config instead of replacing (JabRef#8834)
  Fix eclipse config (JabRef#8835)
  Add Nemo file manager (JabRef#8831)
  Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
  Update bouncycalse to new base version (JabRef#8827)
  add: add test cases for FileUtil (JabRef#8810)
  Restrict use of standard streams (JabRef#8816)
@claell
Copy link
Contributor Author

claell commented May 22, 2022

@calixtus I just checked the behavior. It is correct, also right mouse button clicks and probably further actions can trigger this.

I didn't find a fast solution to this, though. I don't know, how to add an event handler for MouseEvent (that contains information about the button). Help is appreciated. Maybe, this is not how the class was designed.

@claell
Copy link
Contributor Author

claell commented May 22, 2022

Adding a custom subclass of Notifications which has a custom EventHandler also proves difficult, as the class Notifications uses a private constructor.

@claell claell deleted the clel-notification-click branch June 16, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants