Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected #8821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at object does not have
|
Partly fixed, I can still trigger and Index out of Bounds exception by removing the last entry of the group |
2 tasks
|
I just did a few tests with this PR (see #8826) and it seems to work better than Jabref 5.6 stable. There are still other errors and index out of bounds, but at least one of them is gone :-) |
|
Thank you for your feedback @Siedlerchr.
Could you please include steps to reproduce the issue? Additional information:I have tested #8826 with this PR but could not reproduce the issue (in Window 10). Would these issues dependent on operating system? |
|
Here a test of this pr and the related issue about renaming groups (#8826) in the entry-editor general tab using Linux Mint. Bildschirmaufnahme2022-05-19_12_46_47handbrake.mp4Edit: It does not really show in the video, but all I did was to press the Edit2: But I would say that what is shown in this video does not really block this PR from merging, because I can trigger errors when trying to do this also in JabRef 5.6 stable. |
|
As the original exception/error is fixed I would vote to merge this. |
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
approved these changes
May 21, 2022
|
Can you please add a changelog entry? |
|
Hi @Siedlerchr, I have updated CHANGELOG.md file. |
Siedlerchr
added a commit
to Christina0114/jabref
that referenced
this pull request
May 22, 2022
* upstream/main: (109 commits) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816) updated 8802 (JabRef#8817) Bump pascalgn/automerge-action from 0.15.2 to 0.15.3 (JabRef#8803) Bump jackson-dataformat-yaml from 2.13.2 to 2.13.3 (JabRef#8804) Bump icu4j-charset from 70.1 to 71.1 (JabRef#8805) Fix notifications that overlap task bar (JabRef#8775) checkstye Default path for ssl key store is nested inside "JabRef" directory (JabRef#8796) Add log on disk (JabRef#8791) Fix for JabRef#8788 JabRef not showing contents of shared database library (JabRef#8793) ...
Siedlerchr
added a commit
to josepylee/jabref
that referenced
this pull request
May 22, 2022
* upstream/main: Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829)
Siedlerchr
added a commit
to fly-ing-fish/jabref
that referenced
this pull request
May 22, 2022
…-masked-characters#8787 * upstream/main: Add: Add test cases for non-default styles in CitationStyleTest (JabRef#8828) Open event log when clicking on collapsed notification (JabRef#8837) Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (JabRef#8821) Fix single identifier cannot be opened on click (JabRef#8838) Add Pubmed/Medline Query Transformer (JabRef#8818) adjust and add testcases for FileAnnotationViewModel (JabRef#8830) Append config instead of replacing (JabRef#8834) Fix eclipse config (JabRef#8835) Add Nemo file manager (JabRef#8831) Fix missing clear action on pressing esc within the "Filter groups" field (JabRef#8829) Update bouncycalse to new base version (JabRef#8827) add: add test cases for FileUtil (JabRef#8810) Restrict use of standard streams (JabRef#8816)
2 tasks
|
Reverted at 6fd3be5 due to request at #8859 (comment) |
|
Changelog reverted at 5fe375d |
2 tasks
Siedlerchr
added a commit
that referenced
this pull request
Jun 23, 2022
* upstream/main: (27 commits) Add gitpod config (#8921) Fix javafx version not displayed in About Dialog (#8918) Redesign "Manage field names & content" dialog (#8892) Rework IACR fetcher (#8904) Bump h2-mvstore from 2.1.212 to 2.1.214 in /buildSrc (#8915) Bump unoloader from 7.3.3 to 7.3.4 (#8912) Bump libreoffice from 7.3.3 to 7.3.4 (#8913) Bump tika-core from 2.4.0 to 2.4.1 (#8914) Bump org.eclipse.jgit from 6.1.0.202203080745-r to 6.2.0.202206071550-r (#8916) Squashed 'buildres/csl/csl-styles/' changes from e740261..845dee0 (#8903) Bump flowless from 0.6.9 to 0.6.10 (#8898) Bump postgresql from 42.3.5 to 42.4.0 (#8900) Bump mockito-core from 4.6.0 to 4.6.1 (#8899) Bump antlr-runtime from 3.5.2 to 3.5.3 (#8897) Update to MADR 3.0.0-beta.2 (#8896) Increase the network connection timeout and improve error message (#8894) Fix linux terminal opening process error (#8891) Fix exception if linked file has masked umlauts / invalid characters in path (#8851) Remove obsolte CHANGELOG.md entry Revert "Fix right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected (#8821)" ... # Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous discussion about right clicking a group and choosing "remove selected entries from this group" leads to error when Bibtex source tab is selected #8012
Big thank you to @ThiloteE and @Siedlerchr for all the provided information in #8012 that help me to find the root of this issue.
Root of issue #8012
authorandgroupsas fields.111and click on "Remove selected entries from this group", this entry will be deleted and still stay inpreviousEntryandoutOfFocusBoundvariables.previousEntryoroutOfFocusBoundonly haveauthoras field after "Remove selected entries from this group".newEntrywhich has keysauthorandgroups.outOfFocusBounddoes not havegroupsfield, assigning value to a null result in error.Proposed solution
Fixes #8012
Add a validation before setting value to a field.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)