Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BST VM to Antlr4 #8934

Merged
merged 43 commits into from
Aug 1, 2022
Merged

Update BST VM to Antlr4 #8934

merged 43 commits into from
Aug 1, 2022

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Jun 28, 2022 •
edited
Loading

Converts the existing virtual machine for bst entry previews (see https://ctan.joethei.xyz/info/bibtex/tamethebeast/ttb_en.pdf) from antlr3 to antlr4 and removes the existing dependencies to antlr3. There are no changes visible to the user. The changes benefit only the code quality and the developer experience.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

calixtus added 28 commits May 26, 2022 01:26
@calixtus
migrate to antlr4
07a9ccb
@calixtus
apply ide suggestions
08c6a77
@calixtus
Refactor
7a33e9f
@calixtus
Introduce BstVM, wip
7327061
@calixtus
read, entry, sort wip
bb9be35
@calixtus
functions visitor
ad63426
@calixtus
bstEntryContext
56b45c8
@calixtus
function, identifier, stackitem, exception
c30fe48
@calixtus
reorder
9d076e2
@calixtus
execute, iterate, reverse
3e80d20
@calixtus
removed old vm, prepared test architecture
377ad26
@calixtus
fixed parser
3eb676c
@calixtus
fixed stringscommand
220679c
@calixtus
fixed macrocommand
018c3d6
@calixtus
fixed functioncommand
472dcfb
@calixtus
added exception handling for functions
a9f31aa
@calixtus
testVisitEntryCommand
f748f8d
@calixtus
testVisitReadCommand
1ffb6ab
@calixtus
reorder and cleanup
51cc276
@calixtus
testdata cleanup
a6a3a70
@calixtus
fix function call
b95957a
@calixtus
fixed call.type
ceba234
@calixtus
Merge remote-tracking branch 'upstream/main' into update_vm_antlr4
cb6ce40 
# Conflicts:
#	build.gradle
@calixtus
Merge remote-tracking branch 'upstream/main' into update_vm_antlr4
6c663c8
@calixtus
wip if
ce508cc
@calixtus
wip if
424e168
@calixtus
addedTests
b91006d
@calixtus
finally fixed if
9726f3b
@calixtus calixtus marked this pull request as draft June 28, 2022 17:52
@ThiloteE ThiloteE added the type: code-quality Issues related to code or architecture decisions label Jun 30, 2022
@calixtus calixtus marked this pull request as ready for review August 1, 2022 13:11
@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 1, 2022
@Siedlerchr Siedlerchr merged commit 0a1e98b into JabRef:main Aug 1, 2022
@Siedlerchr Siedlerchr deleted the update_vm_antlr4 branch August 1, 2022 19:27
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into GSOC-merge-fields
681edea 
* upstream/main: (21 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Siedlerchr added a commit that referenced this pull request Aug 3, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into GSOC22-Three-Way-Merge
02998c0 
* upstream/main: (39 commits)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  New translations JabRef_en.properties (Spanish) (#9003)
  Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677
  Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e
  Autosave folder and checkbox is remembered (#9000)
  New Crowdin updates (#8999)
  Sync group view mode and main table (#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (#8997)
  Bump java-diff-utils from 4.11 to 4.12 (#8998)
  Fix external group metadata changes are not merged (#8994)
  ...
Siedlerchr added a commit to zkl-ai/jabref that referenced this pull request Aug 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into improve-DOI-import-…
d26e288 
…failure-dialog

* upstream/main: (31 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (JabRef#9030)
  New Crowdin updates (JabRef#9029)
  [Bot] Update CSL styles (JabRef#9027)
  Add missing translations for AutomaticFieldEditor (JabRef#9028)
  [Bot] Update Journal abbrev list (JabRef#9026)
  Rating in main table (JabRef#9023)
  New Crowdin updates (JabRef#9024)
  New Crowdin updates (JabRef#9016)
  New Crowdin updates (JabRef#9013)
  try to gather more output from LO exception (JabRef#9002)
  Improve Automatic Field Editor Dialog (JabRef#8973)
  Update BST VM to Antlr4 (JabRef#8934)
  Support biblatex apa citation for legal entry types (JabRef#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (JabRef#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (JabRef#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (JabRef#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (JabRef#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-8372
e7374f9 
* upstream/main: (185 commits)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005)
  ...
Siedlerchr added a commit that referenced this pull request Aug 6, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/o…
966d87c 
…rg.jsoup-jsoup-1.15.2

* upstream/main: (34 commits)
  Refactor of DOI import failure dialog, import format reader and clipboard manager (#8839)
  Snapcraft and issue template
  Show development information\n\n+semver: minor
  Release v5.7
  New Crowdin updates (#9030)
  New Crowdin updates (#9029)
  [Bot] Update CSL styles (#9027)
  Add missing translations for AutomaticFieldEditor (#9028)
  [Bot] Update Journal abbrev list (#9026)
  Rating in main table (#9023)
  New Crowdin updates (#9024)
  New Crowdin updates (#9016)
  New Crowdin updates (#9013)
  try to gather more output from LO exception (#9002)
  Improve Automatic Field Editor Dialog (#8973)
  Update BST VM to Antlr4 (#8934)
  Support biblatex apa citation for legal entry types (#8966)
  Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012)
  Bump lucene-core from 9.2.0 to 9.3.0 (#9009)
  Bump checkstyle from 10.3.1 to 10.3.2 (#9006)
  ...
This was referenced Apr 25, 2024
Merged
Closed
tsantalis added a commit to tsantalis/RefactoringMiner that referenced this pull request May 18, 2024
@tsantalis
detection of Move and Rename Method in PR
2ae194c 
JabRef/jabref#8934
#715
@koppor koppor mentioned this pull request May 19, 2024
Merged
6 tasks
This was referenced May 27, 2024
Open
Closed
Closed
@tsantalis tsantalis mentioned this pull request May 30, 2024
Open
tsantalis added a commit to tsantalis/RefactoringMiner that referenced this pull request Jun 2, 2024
@tsantalis
Restore mappings for JabRef/jabref#8934 (#715)
2fab3c3 
The commit causes test to fail. Test needs to be updated.
liferay/liferay-portal@59fd9e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
entry-preview status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixtus @Siedlerchr @koppor @ThiloteE