Autosave folder and checkbox is remembered #9000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiloteE
added
component: shared-database
component: preferences
status: ready-for-review
Siedlerchr
approved these changes
Jul 28, 2022
|
Seems right. SharedDbPrefs is not yet converted to the new pattern. So looks good to me. Thanks. |
calixtus
approved these changes
Jul 29, 2022
Siedlerchr
added a commit
to Ognimalf/jabref
that referenced
this pull request
Jul 29, 2022
* upstream/main: Autosave folder and checkbox is remembered (JabRef#9000) New Crowdin updates (JabRef#8999) Sync group view mode and main table (JabRef#8993) Bump unoloader from 7.3.4 to 7.3.5 (JabRef#8996) Bump libreoffice from 7.3.4 to 7.3.5 (JabRef#8997) Bump java-diff-utils from 4.11 to 4.12 (JabRef#8998) Fix external group metadata changes are not merged (JabRef#8994) New Crowdin updates (JabRef#8995) Reworded t in pr (JabRef#8989) Fixed checkstyle (JabRef#8990) Fix RfcFetcherTest (JabRef#8988) Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)
Siedlerchr
added a commit
that referenced
this pull request
Aug 3, 2022
* upstream/main: (21 commits) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005) New translations JabRef_en.properties (Spanish) (#9003) Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677 Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e Autosave folder and checkbox is remembered (#9000) New Crowdin updates (#8999) Sync group view mode and main table (#8993) Bump unoloader from 7.3.4 to 7.3.5 (#8996) Bump libreoffice from 7.3.4 to 7.3.5 (#8997) Bump java-diff-utils from 4.11 to 4.12 (#8998) Fix external group metadata changes are not merged (#8994) ...
Siedlerchr
added a commit
that referenced
this pull request
Aug 3, 2022
* upstream/main: (39 commits) New Crowdin updates (#9016) New Crowdin updates (#9013) try to gather more output from LO exception (#9002) Improve Automatic Field Editor Dialog (#8973) Update BST VM to Antlr4 (#8934) Support biblatex apa citation for legal entry types (#8966) Bump junit-jupiter from 5.8.2 to 5.9.0 (#9012) Bump lucene-core from 9.2.0 to 9.3.0 (#9009) Bump checkstyle from 10.3.1 to 10.3.2 (#9006) Bump appleboy/ssh-action from 0.1.4 to 0.1.5 (#9005) New translations JabRef_en.properties (Spanish) (#9003) Squashed 'buildres/csl/csl-locales/' changes from 55459cd79f..e637746677 Squashed 'buildres/csl/csl-styles/' changes from 3d3573c..c750b6e Autosave folder and checkbox is remembered (#9000) New Crowdin updates (#8999) Sync group view mode and main table (#8993) Bump unoloader from 7.3.4 to 7.3.5 (#8996) Bump libreoffice from 7.3.4 to 7.3.5 (#8997) Bump java-diff-utils from 4.11 to 4.12 (#8998) Fix external group metadata changes are not merged (#8994) ...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this changes, the autosave folder and tick in the shared database opening dialog is remembered for the next time. I introduced these two things as new attributes of
SharedDatabasePreferences.Fixes #7516.
Please check if this changes are as intended. I have seen that there are preference attributes for all other elements of the shared database opening dialog, but not for these two. Maybe there is a reason for that. But I think the new changes more convenient when you frequently open the shared database and want to synchronize the same BIB file everytime.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)