-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observable Preferences T (NameDisplayPreferences, MainTablePreferences, ColumnPreferences) #9535
Conversation
…references in new prefs pattern
Seems to work fine. |
Is the maintable fine? Since this pr is reducing code duplication with the search dialog and the main table, this is probably a bug in the search dialog and hopefully not caused by my changes 😅 . So I agree, a follow up issue (maybe "good first") with bugs in the global search dialog should be filed and adressed |
As far as I remember the columns in the search are just based on the main table but are stored separate. So they should be independent |
So as both reviewers approved or voted to merge, im merging. |
…ialog * upstream/main: Bump xmlunit-core from 2.9.0 to 2.9.1 Bump mockito-core from 4.11.0 to 5.0.0 Bump xmlunit-matchers from 2.9.0 to 2.9.1 Bump junit-platform-launcher from 1.9.1 to 1.9.2 Squashed 'buildres/csl/csl-styles/' changes from 43566f2..50eea55b2c New translations JabRef_en.properties (Portuguese, Brazilian) (#9559) Changed the color of light-color-text and highlighted text in … (#9546) New translations JabRef_en.properties (Portuguese, Brazilian) (#9557) chore: improve debug output in powershell starter script (#9550) Show development information (#9555) Observable Preferences T (NameDisplayPreferences, MainTablePreferences, ColumnPreferences) (#9535)
Follow up to #9493
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)