Observable Preferences U #9619
Merged
Observable Preferences U #9619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
type: code-quality
|
yeah important step! |
koppor
reviewed
Feb 16, 2023
Comment on lines
-518
to
-524
| @ParameterizedTest | ||
| @MethodSource("provideTestFiles") | ||
| void testSaveExternalFilesListToPreferences(TestData testData) throws IOException { | ||
| addFourTestFileToViewModelAndPreferences(testData); | ||
| verify(preferencesService).storeJournalAbbreviationPreferences(any()); | ||
| } | ||
|
|
There was a problem hiding this comment.
From reading the deleted code only, I don't get why it is not replaced by some other testing code -
Shouldn't the preferences then stored be in the abbreviationPreferences?
There was a problem hiding this comment.
Thing is, it does not make sense to test here if the private putBoolean method is called. This should be a test in JabRefPreferencesTests or JournalAbbreviationPreferencesTest, but this is somewhat trivial and I assume the behavior of observers is testet within javafx already.
If you really want to test the view model we should certainly not test with any() as an argument.
With other words: the test, as it is, is useless imho.
Siedlerchr
added a commit
that referenced
this pull request
Mar 14, 2023
…rg.mariadb.jdbc-mariadb-java-client-3.1.0 * upstream/main: (357 commits) Fix syntax Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser (#9641) Update guidelines-for-setting-up-a-local-workspace.md Update guidelines-for-setting-up-a-local-workspace.md Bump org.tinylog:slf4j-tinylog from 2.6.0 to 2.6.1 (#9665) Bump apple-actions/import-codesign-certs from 1 to 2 (#9662) Bump com.puppycrawl.tools:checkstyle from 10.8.0 to 10.8.1 (#9661) Bump gittools/actions from 0.9.15 to 0.10.2 (#9663) Bump hmarr/auto-approve-action from 3.1.0 to 3.2.0 (#9664) Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 (#9666) Bump org.tinylog:tinylog-api from 2.6.0 to 2.6.1 (#9667) Add option to open arks in the browser from an ark identifier (#9601) remove "jdk 19 does not work" (#9658) Fulltext fetcher for IACR eprints (#9651) Observable Preferences S (#9619) Issue 9646: Right-click context menu "Attach file from URL" (#9648) Improve the INSPIREFetcher in "Update with bibliographic information from the web" (#9645) Bump appleboy/ssh-action from 0.1.7 to 0.1.8 (#9653) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9656) Bump com.puppycrawl.tools:checkstyle from 10.7.0 to 10.8.0 (#9655) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9535
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)