Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings from GitHub about Node 12 and set-output being deprecated #1241

Closed
jwodder opened this issue Oct 12, 2022 · 4 comments
Closed

Warnings from GitHub about Node 12 and set-output being deprecated #1241

jwodder opened this issue Oct 12, 2022 · 4 comments
Labels
duplicate 💿 This issue or pull request already exists

Comments

@jwodder
Copy link

jwodder commented Oct 12, 2022

Describe the bug

When running the latest version of this action (@v4), GitHub emits the following warnings as annotations:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: JamesIves/github-pages-deploy-action

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Workflow

https://github.com/jwodder/kbits/blob/master/.github/workflows/deploy.yml
@JamesIves
Copy link
Owner

This has been updated as of version v4.4.1, please let me know if you continue to see this: https://github.com/JamesIves/github-pages-deploy-action/releases/tag/v4.4.1

@JamesIves JamesIves added duplicate 💿 This issue or pull request already exists and removed triage ⚠️ labels Oct 13, 2022
@M3lkior
Copy link

M3lkior commented Oct 24, 2022

hi @JamesIves ; what about the deprecation of set-output ? i don't see the fix in the v4.4.1

@kelvinqian00
Copy link

@M3lkior I performed a test deployment using v4.4.1 and there was no set-output warning. (By contrast, our most recent production deployment was with version 4.1.5 which did have that warning.) So I think we should be good on that regard.

@M3lkior
Copy link

M3lkior commented Oct 26, 2022

ok thanks

@ebouchut ebouchut mentioned this issue Feb 20, 2023
Closed
ebouchut added a commit to ebouchut/loopdocs that referenced this issue Feb 20, 2023
@ebouchut
💚 Remove deprecation warnings when running publish.yml
4ba1a0c 
Fix LoopKit#586
Upgrading to JamesIves/github-pages-deploy-action v4.4.1 to remove
the deprecation warnings:

- Node.js 12 actions are deprecated. Please update the following actions
to use Node.js 16
- The set-output command is deprecated and will be disabled soon

See: JamesIves/github-pages-deploy-action#1241
ebouchut added a commit to ebouchut/loopdocs that referenced this issue Feb 20, 2023
@ebouchut
👷 Upgrade JamesIves/github-pages-deploy-action to v4 from v3
8f87523 
Fix LoopKit#586
💚 Removes the deprecation warnings when running publish.yml:

- Node.js 12 actions are deprecated. Please update the following actions
to use Node.js 16
- The set-output command is deprecated and will be disabled soon

See: JamesIves/github-pages-deploy-action#1241
ebouchut added a commit to ebouchut/looptips that referenced this issue Apr 2, 2023
@ebouchut
👷 Upgrade JamesIves/github-pages-deploy-action to latest v4 from v4.2.5
6d69c44 
 💚 Removes the deprecation warnings when running publish.yml:
  - The set-output command is deprecated and will be disabled soon

See: JamesIves/github-pages-deploy-action#1241

Running the github action publish.yml generates the following
deprecation warnings:

> Warning: The `set-output` command is deprecated and will be disabled
soon. Please upgrade to using Environment Files. For more information
see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

See:
https://github.com/LoopKit/looptips/actions/runs/4587732000/jobs/8101444914#step:6:77
ebouchut added a commit to ebouchut/looptips that referenced this issue Apr 2, 2023
@ebouchut
👷 Upgrade JamesIves/github-pages-deploy-action to latest v4 from v4.2.5
72fd00e 
- 💚 Remove deprecation warnings when running publish.yml:
    - set-output command is deprecated
      See: JamesIves/github-pages-deploy-action#1241
      > Warning: The `set-output` command is deprecated and will be disabled
      > soon. Please upgrade to using Environment Files. For more information
      > https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands
    - Node.js 12 actions are deprecated
      > Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: JamesIves/github-pages-deploy-action@v4.2.5.
      > For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
- 💚 Add content write permission to publish.yml Github Action
  See: JamesIves/github-pages-deploy-action#1285
@ebouchut ebouchut mentioned this issue Apr 2, 2023
Merged
This was referenced May 9, 2023
Merged
Merged
@ksaur ksaur mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate 💿 This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jwodder @M3lkior @JamesIves @kelvinqian00