Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Fix publish.yml deprecation warnings: Node 12 GH actions + set-output #19

Conversation

ebouchut
Copy link
Collaborator

@ebouchut ebouchut commented Apr 2, 2023

⚠️ Running the github action publish.yml generates the following deprecation warnings:

💚 The fix consists in upgrading 2 Github Actions and giving write access to the Github action script:

ebouchut added 2 commits April 2, 2023 13:22
💚 Remove actions/setup-python deprecation warning:
> set-output command is deprecated and will be disabled soon
- 💚 Remove deprecation warnings when running publish.yml:
    - set-output command is deprecated
      See: JamesIves/github-pages-deploy-action#1241
      > Warning: The `set-output` command is deprecated and will be disabled
      > soon. Please upgrade to using Environment Files. For more information
      > https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands
    - Node.js 12 actions are deprecated
      > Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: JamesIves/github-pages-deploy-action@v4.2.5.
      > For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
- 💚 Add content write permission to publish.yml Github Action
  See: JamesIves/github-pages-deploy-action#1285
Copy link
Collaborator Author

@ebouchut ebouchut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@ebouchut ebouchut merged commit 8ae5f7a into LoopKit:master Apr 2, 2023
@ebouchut ebouchut added the config label Apr 2, 2023
@ebouchut ebouchut deleted the fix_publish_deprecation_warnings_node_16_set_output branch April 2, 2023 14:05
@ebouchut
Copy link
Collaborator Author

ebouchut commented Apr 3, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant