Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exemptions #106

Merged
merged 19 commits into from
Jan 12, 2021
Merged

feat: exemptions #106

merged 19 commits into from
Jan 12, 2021

Conversation

themightychris
Copy link
Member

@themightychris themightychris commented Jan 4, 2021 •
edited
Loading

Closes #99

Why

The ability to exempt traffic based on IP match or pattern is needed in addition to the ability to do it based on key

What

  • Refactor Key->RateLimitExempt field to new Exemption table
  • Migrate existing exempt keys to exemptions table
  • Add CRUD for exemptions
  • Add dedicated per-exemption option for whether exemption applies to endpoint (global) rate limits
  • Optimize IP pattern matching library for better cross-functional use

@themightychris
chore: bump skeleton-v2 version to v2.5.0
d4af615
@themightychris
feat: use Client::getAddress in place of REMOTE_ADDR
624af54
@themightychris
chore: bump skeleton-v2 to 2.5.1
4ddfc8e
@themightychris
fix: revert method of checking test API access
9e3b098 
The original method worked better
@themightychris
feat: add client IP test API
cb02b07
@themightychris
feat(fixtures): add endpoints for all test API endpoints
57c7dfc
@themightychris
feat: add headers test endpoint
f9f9d61
@themightychris
refactor: track client address in ApiRequest state
6995267
@themightychris
feat: add basic CRUD for exemptions
bb40928
@themightychris
chore: remove unneeded import and unused use
16f8b49
@themightychris
refactor: embed all caching within IPPattern util and simplify API
4ebbc77
@themightychris
refactor: add match() method to IPPattern utility
d9494b3
@themightychris
feat: load exemption record into ApiRequest early in pipeline
bb8aa73
@themightychris
feat: apply exemptions to user-level rate limits
46804e9
@themightychris
refactor: rename BypassGlobalLimit to BypassEndpointLimits
772ae40
@themightychris
feat: make BypassEndpointLimits editable
6b55e95
@themightychris
feat: apply exemptions with BypassEndpointLimits to endpoint rate limits
e4fa020
@themightychris
feat(fixtures): add exemption and key fixtures
0bbdeb9
@themightychris themightychris added this to the v3.1 milestone Jan 4, 2021
@github-actions github-actions bot temporarily deployed to pr-106 January 4, 2021 23:10 Inactive
@github-actions github-actions bot temporarily deployed to pr-106 January 5, 2021 00:05 Inactive
@themightychris themightychris merged commit 5463b91 into develop Jan 12, 2021
@themightychris themightychris deleted the features/exemptions branch January 12, 2021 22:15
@themightychris themightychris mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

web-editable exempt IPs table
1 participant
@themightychris