Add support for encrypted notifications #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.63% // Head: 68.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 69.63% 68.29% -1.35%
==========================================
Files 71 71
Lines 6152 6361 +209
==========================================
+ Hits 4284 4344 +60
- Misses 1868 2017 +149
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
It looks like these are widely supported I haven't been able to get anything to give up a key yet but I think I might need to turn at least one on first |
Jc2k
reviewed
Oct 21, 2022
|
home-assistant/core#80733 to open up the filter |
bdraco
commented
Oct 22, 2022
bdraco
changed the title
|
Works well with dropped advertisements as well as the the next adv gets picked up and it makes a connection |
bdraco
commented
Oct 22, 2022
|
Found a race on first connection |
|
Tested with my Eve Motion first, it was just the first thing i pulled out my drawer: Success! |
|
An |
Jc2k
approved these changes
Oct 22, 2022
…ve been since it calls put_characteristics which is wrapped
|
verified its recovering ok when accessory isn't available at startup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now try to get the char change via an encrypted notification instead of a disconnected
event when possible. This avoids the need to connect to the accessory for changes that
are made to it from outside of aiohomekit which drastically speeds up updates and frees
up BLE connection slots.