Remove workaround to populate missing handles #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the user was running an older version. As its been a few months, everyone should have the missing handles populated now, and since this check is rather expensive to run every operation, we should remove it.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 67.55% 67.61% +0.06%
==========================================
Files 72 72
Lines 6811 6803 -8
==========================================
- Hits 4601 4600 -1
+ Misses 2210 2203 -7
☔ View full report in Codecov by Sentry. |
Jc2k
approved these changes
Jul 17, 2023
|
thanks |
|
I'll push a release soon (not for backport). Didn't have time to do it earlier since I'm traveling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#197 added a check for missing handles if the user was running an older version. As its been a few months, everyone should have the missing handles populated now, and since this check is rather expensive to run every operation, we should remove it.