-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🩹 (┛ಠ_ಠ)┛彡┻━┻) NICE-126 patch commit-analyzer@13 [b] (#1493)
Seems to be skipping upgrades, which, you know are important. # (┛ಠ_ಠ)┛彡┻━┻ At the risk of coming off as rude, this is a hack patch. Please move away from `semantic-release`. ## (┛ಠ_ಠ)┛彡┻━┻ ## (┛ಠ_ಠ)┛彡┻━┻ ## (┛ಠ_ಠ)┛彡┻━┻ ## (┛ಠ_ಠ)┛彡┻━┻ ## (┛ಠ_ಠ)┛彡┻━┻ ## Example: ⬆️ (deps) @radix-ui/themes@3.1.1 Would not trigger a build (in a non-packages repo).
- Loading branch information
1 parent
048bce0
commit 1c35c6a
Showing
11 changed files
with
81 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,4 @@ | ||
If `conventional-gitmoji` updated and this package has not | ||
modify this file to force a build (until automation) | ||
modify this file to force a build (until automation) | ||
|
||
Testing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
diff --git a/lib/analyze-commit.js b/lib/analyze-commit.js | ||
index 35a4e7d1aa4acc25a5dbeb36d7d58db23b50b7e7..90c8663686db553974e8fca342d73a4a59d8639f 100644 | ||
--- a/lib/analyze-commit.js | ||
+++ b/lib/analyze-commit.js | ||
@@ -18,14 +18,28 @@ export default (releaseRules, commit) => { | ||
releaseRules | ||
.filter( | ||
({ breaking, revert, release, ...rule }) => | ||
- // If the rule is not `breaking` or the commit doesn't have a breaking change note | ||
- (!breaking || (commit.notes && commit.notes.length > 0)) && | ||
- // If the rule is not `revert` or the commit is not a revert | ||
- (!revert || commit.revert) && | ||
- // Otherwise match the regular rules | ||
- isMatchWith(commit, rule, (object, src) => | ||
- isString(src) && isString(object) ? micromatch.isMatch(object, src) : undefined | ||
- ) | ||
+ // // If the rule is not `breaking` or the commit doesn't have a breaking change note | ||
+ // (!breaking || (commit.notes && commit.notes.length > 0)) && | ||
+ // // If the rule is not `revert` or the commit is not a revert | ||
+ // (!revert || commit.revert) && | ||
+ // // Otherwise match the regular rules | ||
+ // isMatchWith(commit, rule, (object, src) => | ||
+ // isString(src) && isString(object) ? micromatch.isMatch(object, src) : undefined | ||
+ // ) | ||
+ | ||
+ { | ||
+ if ( | ||
+ (!breaking || (commit.notes && commit.notes.length > 0)) && | ||
+ (!revert || commit.revert) && | ||
+ isString(commit.subject) && isString(rule.type) && | ||
+ micromatch.contains(commit.subject, rule.type) | ||
+ ) { | ||
+ return { | ||
+ ...commit, | ||
+ ...rule | ||
+ } | ||
+ } | ||
+ } | ||
) | ||
.every((match) => { | ||
if (compareReleaseTypes(releaseType, match.release)) { |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.