Feature/grouped line charts #206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replicated the structure for grouped bar charts for stacked bar charts. Also, seperated out the generation of extent, indexes, and series for stacked bar so they could be overriden for grouped data.
Added a Grouped story for StackedBarChart. It seems like I'm doing something wrong here, generate enough areas, but some of them have `NaN` in the path data.
The stacked bar groups no longer extends the stacked bars because everything is now overriden. The last issue I had was that the last group kept coming out with NaN in its path data. This was due to the miscalculation of the Scale based on the indexes of the top level data as Stacked Bars does it. Also, the indexes needed to be calculated off of the number of groups instead of the number of total bars. Also removed any test code left in.
Added a story for horizontal groups of stacked bars.
Group StackBarChart & Bar
Duplicated Chart but altered it to use the standard grouping data structure and implemented a line gate that produces a path for each line. Also added a story for a grouped set of lines.
Remove commented out extranious imports.
|
Sorry, this depends on #204 |
|
Thanks for another awesome contribution 🥇 |
|
Sorry, I'll take some time and cherrypick this and #208 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to group line charts together addressing #205. This uses the same data structure as grouping bar charts:
I've confirmed that all lines display correctly and that all children can receive touch events.