Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouped Line Charts #240

Merged

Conversation

alburdette619
Copy link
Collaborator

#206 but without PR pollution from other branches and based off current dev

Adds the ability to group line charts together addressing #205. This uses the same data structure as grouping bar charts:

data: [
  { data: [], svg: {} },
  ...
]

I've confirmed that all lines display correctly and that all children can receive touch events.

Duplicated Chart but altered it to use the standard grouping data structure and implemented a line gate that produces a path for each line.  Also added a story for a grouped set of lines.
Remove commented out extranious imports.
@JesperLekland
Copy link
Owner

This looks super promising! I'll make sure to test it thoroughly asap.
How does a decorator know which path it's decorating?

@alburdette619
Copy link
Collaborator Author

The x and y functions return regardless and each data array contains only one set of line data. Other props are passed along with the data. Thus far I haven't needed to specifically know.

@JesperLekland JesperLekland merged commit 26e5cc4 into JesperLekland:dev Dec 15, 2018
@avinashtadavarthy
Copy link

avinashtadavarthy commented Jun 26, 2019

@JesperLekland @alburdette619
It has been added into the github project but it hasnt been updated on npm. So any npm downloaded library file comes without the group line and group stacked js files. Please update it on npm.

@Charanor
Copy link

How does one use this with xAcceessor and yAccessor props @alburdette619? I can't seem to figure that one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants