Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At the 10pt on non retina 0 looking like 8 #188

Closed
philippnurullin opened this issue Mar 25, 2020 · 16 comments
Closed

At the 10pt on non retina 0 looking like 8 #188

philippnurullin opened this issue Mar 25, 2020 · 16 comments
Labels
enhancement New feature or request
Milestone

Comments

@philippnurullin
Copy link
Member

image

@philippnurullin philippnurullin added the enhancement New feature or request label Mar 25, 2020
@philippnurullin philippnurullin changed the title At the non retina 10pt 0 looking like 8 At the 10pt on non retina 0 looking like 8 Mar 25, 2020
@AlsoScratch
Copy link

AlsoScratch commented Mar 27, 2020

The problem I see is that the sides of the 8 are not contoured enough.
Anyway, have you tried slashed zero?

@yvvt0379
Copy link

yvvt0379 commented Mar 28, 2020

Enable the stylistic set 'zero' if your editor supports. e.g. if you're using vscode, add "editor.fontLigatures": "'zero'" to the settings.json file.

@AlsoScratch
Copy link

Understood, but the problems I see @philippnurullin have are:

  • It's not clear the dot in the zero is detached from the sides
  • The contours of the sides of the 8 are not clear enough, failing to give the proper '8' shape

@philippnurullin
Copy link
Member Author

The problem is cannot be solved by changing zero to slashed. It doesn't make any difference in small size. The possible solution is make sset with zero with different form.

@epa
Copy link

epa commented Apr 28, 2020

I find that even on a hi-dpi display the 0 and 8 are hard to tell apart.

When programming, distinguishing 0 from O is only moderately important. It just isn't a common mistake to mix them up, beyond the most basic beginner level. Unless you write l33tspeak you won't have long runs of characters where 0 and O both appear. And if you do somehow muddle them, almost any programming language will give a syntax error.

But 0 and 8, on the other hand, commonly appear next to each other in numbers and there is no warning or error from the computer if you confuse them. It's more important for a typeface to have a clear distinction between the different digits than it is between 0 and O, or 2 and Z, 1 and I, etc.

I think you should reconsider the dotted zero and either make it a much smaller dot, or have the 0 as a thin ellipse without dot.

@philgyford
Copy link

For what it's worth, having been the one to point this out and so feeling somehow responsible, here are some other examples of typefaces I happened to have installed, all in MacVim at 10px using Solarized theme.

Screenshot 2020-04-28 at 10 34 05

Zoomed 400%:

Screenshot 2020-04-28 at 10 34 05 zoom

Some are easier than others to distinguish, even with dots or slashes. But I wouldn't presume to tell the designers how best to fix this for JetBrainsMono :)

@jozsefk9
Copy link

For what it's worth, having been the one to point this out and so feeling somehow responsible, here are some other examples of typefaces I happened to have installed, all in MacVim at 10px using Solarized theme.

Screenshot 2020-04-28 at 10 34 05

Zoomed 400%:

Screenshot 2020-04-28 at 10 34 05 zoom

Some are easier than others to distinguish, even with dots or slashes. But I wouldn't presume to tell the designers how best to fix this for JetBrainsMono :)

I can distinguish better without zoom in :-) By the way, "a" and "o" in Monaco are almost the same.

@philippnurullin philippnurullin added this to the v2.002 milestone Jul 16, 2020
@riggs
Copy link

riggs commented Sep 4, 2020

The lack of distinction between the characters 0 8 B is my biggest criticism of the font. I've been using it since it came out, but have been dealing with a lot of hex opcodes recently where this issue is thrust front & center for me:
Screen Shot 2020-09-03 at 9 09 10 PM

@astrolemonade
Copy link

Try the latest version, the zero has been improved

@philippnurullin
Copy link
Member Author

@riggs This looks like one of the old releases of JetBrains mono on your screen. Try to upgrade to the latest version & see if you have more pleasant experience.

Overall, thanks for the input. I'll see what can be improved.

@yvvt0379
Copy link

yvvt0379 commented Sep 6, 2020

Yeah, this is v1.0.3.

@riggs
Copy link

riggs commented Sep 6, 2020

It's the current version in the 3 JetBrains IDEs I use (and update) regularly, so perhaps something could be done to include font updates more expediently.

philippnurullin added a commit that referenced this issue Oct 21, 2020
Major changes
— Added Greek alphabet #58
— Reworked diacritics #228
— Removed x-height increasing from hinting. Affects non Retina screens. #286 #265 #272 #262 #275
— A lot of tiding up of contours to meet Google Fonts criteria
Other updated and fixes
— Ligature for 0x (hexadecimal) prefix #98
— Lowered horizontal bar in Florin to make it more distinguishable form italic f #129
— Changes the 8 construction to make it more distinguishable from B and 0 #188
— Added Changelog #263
— Variable font correctly grouped in one family with Italics #270
— Reverted to previous construction of f #273
— Corrected OneNote line height #278
— Removed kerning pair #297
— Add Overline #298
— Increased difference between hyphen, en-dash, and em-dash #318
— Removed the "tail" in the italic a
@trygveaa
Copy link

Unfortunately, I think the 8 looks worse in 2.200 on my machine. It's a lot less clear in the middle and seems to be squished together.

2.200:
image

2.002:
image

This is with font size 11 in the kitty terminal emulator on Arch Linux, using a 1920x1080 96 DPI display.

@jozsefk9
Copy link

This is 2.200, 9pt, Konsole:
jetbrains mono 2 200 9pt_20201022_075826
Works fine for me.

@philippnurullin
Copy link
Member Author

The original request was that the 8 is too similar to 0 + B was added to the list later.
Here is a comparison. The difference in letters is achieved so i'm closing this issue.

Screenshot 2020-10-22 at 11 42 18

Screenshot 2020-11-16 at 12 52 11

@trygveaa Yes indeed the 8 can be made a bit wider. I will try to improve it the next update.

@yvvt0379
Copy link

yvvt0379 commented Jan 1, 2021

Hey, so when will it be modified? At present the figure 8 construction looks inconsistent with font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants