Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

# looks worse in version 2 on small font sizes #275

Open
trygveaa opened this issue Jul 13, 2020 · 11 comments
Open

# looks worse in version 2 on small font sizes #275

trygveaa opened this issue Jul 13, 2020 · 11 comments
Labels
hinting bug
Milestone
v2.300

Comments

@trygveaa
Copy link

Version 1.0.6:
image

Version 2.001:
image

In version 2 the horizontal bars are not centered vertically. The lines above them are longer than the lines below.

This is with font size 11 rendered in kitty. With font size 100 they are almost identical.

Version 1.0.6:
image

Version 2.001:
image
@philippnurullin
Copy link
Member

Ok, will try to improve it in the next update.

@philippnurullin philippnurullin mentioned this issue Jul 15, 2020
Closed
@philippnurullin philippnurullin added this to the v2.002 milestone Jul 16, 2020
@rednafi
Copy link

rednafi commented Jul 24, 2020 •
edited
Loading

The font got compressed horizontally. Version 1 looks considerably better and this version doesn't look anything like the one shown in the Jetbrains website. Falling back to version 1.0.6

@philippnurullin
Copy link
Member

@rednafi This issue is not related, please create a separate one & include screenshots of new version + old so i can investigate it.

philippnurullin added a commit that referenced this issue Oct 21, 2020
@philippnurullin
2.200
4de9965 
Major changes
— Added Greek alphabet #58
— Reworked diacritics #228
— Removed x-height increasing from hinting. Affects non Retina screens. #286 #265 #272 #262 #275
— A lot of tiding up of contours to meet Google Fonts criteria
Other updated and fixes
— Ligature for 0x (hexadecimal) prefix #98
— Lowered horizontal bar in Florin to make it more distinguishable form italic f #129
— Changes the 8 construction to make it more distinguishable from B and 0 #188
— Added Changelog #263
— Variable font correctly grouped in one family with Italics #270
— Reverted to previous construction of f #273
— Corrected OneNote line height #278
— Removed kerning pair #297
— Add Overline #298
— Increased difference between hyphen, en-dash, and em-dash #318
— Removed the "tail" in the italic a
@philippnurullin
Copy link
Member

Please cofirm or deny the change in the latest update https://github.com/JetBrains/JetBrainsMono/tree/master/fonts
Screenshots are very welcome.

@philippnurullin philippnurullin modified the milestones: v2.200, v2.300 Nov 16, 2020
@rednafi
Copy link

rednafi commented Nov 17, 2020 •
edited
Loading

Looks like v2.200 solves my problem. Thank you!

@trygveaa
Copy link
Author

trygveaa commented Nov 17, 2020 •
edited
Loading

# looks exactly the same for me in 2.211 as in 2.001 (I took a screenshot and compared pixel by pixel).

image

The lines above them are longer than the lines below.

I noticed now that I wrote wrong in the original post. It's the opposite, the lines below are longer.

philippnurullin added a commit that referenced this issue Apr 21, 2021
@philippnurullin
2.230
f668e09 
- Made triple equal ligature === more spacious #25
- Added 70 symbols from #47
- Tuned # #275
- Added =: ligature #305
- Added floor and ceiling mathematical characters #328
- Corrections in Θ θ ξ Σ ∑ #351
- Added Cyrillic Kazakh letters #391
- Added ligature ;;; #393
- The ligature <- have 3 digit exclusion #403
- Fixed regression with <-- ligature #417
- Fixed interpolation error in Italic #431
- Corrected placement of * in */ ligature in Regular master
- Tuned Ч ч
- Rounded corners in ⚠
@philippnurullin
Copy link
Member

Please look at files in the recent push. Tuned the # a bit.

@trygveaa
Copy link
Author

Great, now it looks the same as in 1.0.6 again. Thanks!

The ligatures for ##, ###, #### are still problematic though. And I'm not sure if there are more ligatures involving #?

One thing that's still not perfect though is that for me (font size 11, dpi 96) the top right and bottom left bars are somewhat less prominent than the top left and bottom right. This was the case with 1.0.6 too though (2.230 is pixel perfect with that on this font size/dpi as far as I can see). Not sure if this can be fixed?

How it looks:
image

Zoomed in you can see that the top right and bottom left bars use dimmer colors.
image

@philippnurullin
Copy link
Member

philippnurullin commented Apr 21, 2021 •
edited
Loading

Thanks! The dependent symbols are left as is. I wanted to confirm the positive change first and change the rest after.
Will update them in the next update.

About the blurry leg I'll see what can be done but not expect much. There are a lot of combinations of screens so the solid compromise is what we aiming for. ) The perfection is achieved if you want to show font only on the one particular screen that uses one rasteriser.

@trygveaa
Copy link
Author

About the blurry leg I'll see what can be done but not expect much. There are a lot of combinations of screens so the solid compromise is what we aiming at. ) The perfection is achieved if you want to shew font only on one particular screen that uses one rasteriser.

Alright, I understand, I sort of expected that.

philippnurullin added a commit that referenced this issue Jul 14, 2021
@philippnurullin
2.240
dd6b1d4 
- Added Control code support #241
- Update all # dependent glyphs #275
- Added Ɛ ↋ ↊ ૪ #356
- Changed the look of ~@ ligature #415
- Added EMQuad (u+2001) #439
- The tail of Italic “f” made shorter #441
- Reworked ⚠️ #450
- Added SemiBold weight #453
- Added more anchors to the marks #463
- Added replacement (u+FFFD) #461
- Added zeroWidthNoBreakSpace (u+FEFF) #467
- Fixed consistent of J in italic
@philippnurullin
Copy link
Member

Added the change to all dependent glyphs.
Yo can grab the files here https://github.com/JetBrains/JetBrainsMono/tree/master/fonts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hinting bug
Projects
None yet
Milestone
v2.300
Development

No branches or pull requests
3 participants
@trygveaa @rednafi @philippnurullin